Coder Social home page Coder Social logo

Comments (11)

schmunk42 avatar schmunk42 commented on August 17, 2024 1

Any chance to make this happen?

It should be released as 3 different packages. E.g. ckeditor/ckeditor (standard), ckeditor/ckeditor-basic, ckeditor/ckeditor-full

composer/composer#6489 (comment)

[edit]
Maybe additional three repos automatically splitted?

from ckeditor4-releases.

schmunk42 avatar schmunk42 commented on August 17, 2024

That does not work in general with composer libraries. You simply do not see the versions unless you're on stability dev.

from ckeditor4-releases.

schmunk42 avatar schmunk42 commented on August 17, 2024

This is what worked for us: "ckeditor/ckeditor": "~4.7.0+full"

This is what worked: "ckeditor/ckeditor": "dev-full/4.7.x as 4.7.0" (full/4.7.0 does NOT work for some reason)

@oleq @Reinmar @mlewand To my understanding, using a / in the version tag is not covered by semver. Build metadata should be annotated with a + sign, see http://semver.org/#spec-item-10

from ckeditor4-releases.

rdoursenaud avatar rdoursenaud commented on August 17, 2024

Thanks @schmunk42 for your insights.
Your latest suggestion pins the release but not the specific version.
I worked around it by adding the tag.
It's not very legible but does the trick for now.

The documentation still needs updating though…

from ckeditor4-releases.

mlewand avatar mlewand commented on August 17, 2024

It looks that Comopser is simply not handling tags that way, since branches are working correctly. You can see Fetching a Particular Build Preset section in our docs to find pretty much what @schmunk42 has suggested, so the docs are fine here.

As for workaround, since Composer doesn't play well with tags that contain backslash, you could simply pin the requirement to a given hash.

To my understanding, using a / in the version tag is not covered by semver. Build metadata should be annotated with a + sign, see http://semver.org/#spec-item-10

Yes, these branches do not follow SemVer - we simply added them to allow devs to fetch a particular build.

from ckeditor4-releases.

rdoursenaud avatar rdoursenaud commented on August 17, 2024

@mlewand Thanks for your comment.
The docs are indeed fine but the blog I linked in my first message is not.
Unfortunately it's the first Google result for "ckeditor composer" hence my mixup.
Sorry for the confusion.

from ckeditor4-releases.

schmunk42 avatar schmunk42 commented on August 17, 2024

I haven't really tested it, but would you consider an additional tag like 4.7.0+full if it would work fine?

from ckeditor4-releases.

schmunk42 avatar schmunk42 commented on August 17, 2024

The problem with composer and multiple distributions is, because of the fact that ckeditor is often included as a dependency, that you can not specify a version constraint like ^4.2.1.

If you wanna include a full version, you have to "patch" your root composer.json pointing to a specific branch or version, which makes package management with dependency resolution useless in this setup.

Would be really nice, if you could provide a solution for this.

from ckeditor4-releases.

mlewand avatar mlewand commented on August 17, 2024

And how would Composer resolve anything like ^4.7.0+full? I'm afraid that it will simply skip meta info, and will just use any other preset. That's a no-go for us if it would replace 4.x.x+basic with a 4.x.x+full or the other way around during the update.

from ckeditor4-releases.

schmunk42 avatar schmunk42 commented on August 17, 2024

Tried it with a fork and it does not work :(

See my issue in composer/composer...

from ckeditor4-releases.

mlewand avatar mlewand commented on August 17, 2024

It is a possibility, I created #69 for this, however it's not a hi priority for us ATM as it will require a bit of work to make it happen (and maintain backward compat).

from ckeditor4-releases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.