Coder Social home page Coder Social logo

Comments (5)

Reinmar avatar Reinmar commented on August 17, 2024

I don't think there's any problem with these files. They are not sent to the end user, so that would only save a few KBs on the server's disk and the downloaded directory would be slightly cleaner. On the other hand one may need the basic help contained in README or may want to check the change log.

Since there's no strong reason we'll not touch anything now. We'll keep the issue opened though and if more developers will be interested in this change, then we'll do it.

from ckeditor4-releases.

neon64 avatar neon64 commented on August 17, 2024

How hard is it to implement? I say if it is easy enough (sounds like it) then why not?

from ckeditor4-releases.

Reinmar avatar Reinmar commented on August 17, 2024

It's trivial to implement. The question is - why should we change this?

from ckeditor4-releases.

g00glen00b avatar g00glen00b commented on August 17, 2024

@Reinmar Because IDE's are not made for having such a large filebase. Let's say that your project depends on 10 libraries that all have 325 files, then it means that you have 3250 files in your IDE. Most IDE's like Aptana and Eclipse will have problems with these, because they attempt to run validations on them, scan the files, ..., causing the IDE to hang for several seconds.

My current solution is to add a resource filter to ignore these folders, but that comes at a cost as well, since autocompletion (for example when adding the <script> tag to your HTML file) will no longer work since the file is not recognized by the IDE.


A second problem is, that if you're putting your project under version control, you don't want all these files to be versioned as well. So I would have to ignore them myself.


The real problem (imo) is that if you have a dependency on a library, you only want to add the library itself to your project dependencies, not all the demos, documentation, info, readme's, ... . I mean, if you compare that to the Java world and Maven, then you will also only get the binaries you need, not the Javadocs, examples, ... . If you want those, you just visit the project webpage and download the source.

from ckeditor4-releases.

Reinmar avatar Reinmar commented on August 17, 2024

I tried once loading CKEditor in some IDE and it crashed because CKEditor is 150k lines of JS code. Should I remove some files from my project? No, I should configure the IDE better, or use a better IDE, or a simpler code editor if such IDE does not exist.

Then, you wrote yourself that 16% of the files in CKEditor package are samples. Will these 16% of HTML and MD files save your IDE? I don't think so. If something is a problem, then it's the JS files.

Then, we've got users which will install CKEditor using Bower or Composer and won't find any help inside it. Next day we'll have a confused users which won't even file an issue, because most of them will be beginners or simply won't care. Additionally, we'll have to review all our docs looking for places where we said that there's a samples/ directory in the package.

Last but not least, I agree with you. There should be less samples and documentation in the production package. And we are working on leaving just one simple HTML sample with an additional tool for toolbar configuration. All other samples will moved to so called CKEditor SDK. We hope to have it ready for CKEditor 4.5.0.

from ckeditor4-releases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.