Setting deploy to false still pushes the configuration to the switch about ansible-dcnm

[mikewiebe]

@micruzz82 Thanks for opening the issue. We are working on a fix. Thanks!

[micruzz82]

thanks for the quick turn around and clarification @mikewiebe. I did indeed cp ps from the docs to run the ansible playbook. I'll test this out later today and if all is good will report back.

[micruzz82]

It would be good if you set the global default to false rather than true. This way a user is explicitly stating they want to push the config from the code.

[mikewiebe]

@micruzz82 I was able to figure out what is happening. You probably cut and pasted your first dcnm_policy task from our example documentation but there is a problem with the indentation in the docs.

The deploy: flag and state: flags need to be indented at the same level as the config: parameter.

For example, the following is valid:

    - name: Create policy
      cisco.dcnm.dcnm_policy:
        fabric: "{{ fabric_name }}"
        state: merged
        deploy: false
        config:
          - name: wiebe55  # This must be a valid template name
            create_additional_policy: false  # Do not create a policy if it already exists
            priority: 101

          - switch:
              - ip: "{{ leaf1 }}"

But the following is not valid and the deploy and merge flags will be ignored since they are children of config: in this context. This is a bug that we need to fix but for now, just make sure the indentation for the deploy: and state: parameters are at the same indentation level as config:

    - name: Create policy
      cisco.dcnm.dcnm_policy:
        fabric: "{{ fabric_name }}"
        config:
          - name: wiebe55  # This must be a valid template name
            create_additional_policy: false  # Do not create a policy if it already exists
            priority: 101

          - switch:
              - ip: "{{ leaf1 }}"
            deploy: false
            state: merged

We will fix the documentation and generate a user error if the deploy: and state: parameters are added under config.

[mikewiebe]

@micruzz82 I also just opened the following PR to fix the doc issues

#59

[mikewiebe]

It would be good if you set the global default to false rather than true. This way a user is explicitly stating they want to push the config from the code.

We are trying to keep this module consistent with our other modules that have a deploy option so we don't plan to change the default value. We wanted to use a default that completes the workflow (create object and deploy) but still give users the option to stop short of deploy by setting the value to false.

[micruzz82]

no thats perfectly fine @mikewiebe I've also tested the code and it works great now after fixing the indent. I will test out further the policy module as I also had a few other issues during running the ansible playbook so will raise a separate issue.

For this one, I know you've marked this as a bug so if you think you will track this internally, please feel free to close down this issue.

Thanks again and great effort on getting the ansible modules working. No doubt it will simplify deployment much faster than manual configuration on the web gui.