reserved identifier violation about openh264

[volvet]

This identifiers is used as define guard for header file include, What's is your suggestion to name those guards for C++ standard fitting? Thanks.

[andreasgal]

should we use #pragma once instead of include guards?

[elfring]

I would like to add another thought for your interest in the construct "#pragma once".
How do you think about to reuse also a name pattern like it is applied in other projects?

[cpeterso]

You just need to remove leading underscores to avoid pedantic concerns about identifier names reserved by the C or C++ standards.

#pragma once is not standardized and may be confused by symlinks or case insensitive file systems.

[andreasgal]

We will not have symlinks or case sensitive collisions. Lets be pragmatic and sufficient, not precise and puritan.

[ekr]

I'm not overly worried about case collisions, and while we do have
some name duplication, we are working to remove that. With that
said, I would prefer to stick with standard C++ and so use standard
include guards rather than #pragma once.

I agree we should eventually replace these include guards with ones
that don't have leading underscores.

[ethanhugg]

I agree with EKR that we should probably just remove the leading underscores.

[elfring]

How do you think about to delete an underscore also from an identifier like "_WelsLogicalProcessorInfo"?