Coder Social home page Coder Social logo

Comments (14)

notbrood avatar notbrood commented on July 18, 2024

Can I start workiing on this?

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

Can I start workiing on this?

cc : @vedant-jain03

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

Hey @Tanmoy741127, do you think it would be UI friendly if there was no spinner blocking the view? I have added a bool function which checks if the request is finished, and then only allows the user to star the project again, what are your views on that?

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

@notbrood
That will work. Try out how it will look,
if you can add a little spinner or pulse type of loader in the box of the star icon

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

@Tanmoy741127
Just wanted to let you know that I'm not very comfortable with the get state management aspect of our project. I could try working on it, but I don't think I have the necessary skills to do it properly.

Regarding the bool function, I'm happy to create a PR for the function, and let someone else add the spinner.

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

@notbrood in the mobile-app we are using Provider for state management solution and GetX is using for different purposes. So you can give it a try.

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

Okay, I'll give it a try!

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

I was able to, It looks UI Friendly as well!

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024
2023-03-08.03-56-08.mp4

Here's how it looks! What are your views?

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

Here's how it looks! What are your views?

Great ! Try to make the size same as the star icon

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

I did, how does this look?

2023-03-08.13-28-40.mp4

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

I did, how does this look?

It's looking good now !

from mobile-app.

notbrood avatar notbrood commented on July 18, 2024

Okay, I'm going to make a PR for this now!

from mobile-app.

tanmoysrt avatar tanmoysrt commented on July 18, 2024

Okay, I'm going to make a PR for this now!

I did, how does this look?

cc @manjotsidhu @aman-singh7

from mobile-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.