Comments (1)
Thanks @willfindlay. I think I know what this issue is here.
We need to wait for the pipes before we call cmd.Wait()
From: https://pkg.go.dev/os/exec#Cmd.StderrPipe
It is thus incorrect to call Wait before all reads from the pipe have completed.
So something like the code below, I think. Have a bunch of other things in flight now, but will do a PR on this next.
(other tests also need to be fixed).
@@ -47,14 +47,7 @@ func TestCopyFd(t *testing.T) {
if err != nil {
t.Fatal(err)
}
-
- go func() {
- logOut(t, "stdout> ", testPipes.StdoutRd)
- }()
-
- go func() {
- logOut(t, "stderr> ", testPipes.StderrRd)
- }()
+ defer testPipes.Close()
// makeSpecFile creates a new spec file bsed on the template, and the provided arguments
makeSpecFile := func(pid string) string {
@@ -86,6 +79,9 @@ func TestCopyFd(t *testing.T) {
t.Fatal(err)
}
+ logWG := testPipes.ParseAndLogCmdOutput(t, nil, nil)
+ logWG.Wait()
+
from tetragon.
Related Issues (20)
- K8s Spec Mistmatch for uprobes HOT 2
- docs: demo application `xwing` doesn't have `vi` HOT 1
- docs(Advanced Process execution): `/bin/busybox` is not executed by `id` HOT 4
- TracingPolicies do not get applied in WSL2 HOT 3
- Run multi-kernel Go tests (vmtests) on arm64
- Update code generation scripts with k8s v1.30 libraries HOT 1
- Improve metrics library to enforce best practices
- Documentation: broken links automatic report HOT 1
- v1.1.0 release
- Tetragon with ociHookSetup.enabled cannot start in a namespace other than kube-system
- Enable users to add namespace exceptions in case OCI hook fails
- Tetragon based file integrity monitoring (FIM) HOT 7
- tetragon: better identification of kernel threads HOT 1
- Documentation: broken links automatic report HOT 1
- Tetragon is not showing process exec ancestors HOT 1
- sensor manager: allow concurrent listing with loading.
- BTF: fix validation warnings
- Tetragon Go Test failing on actuated-arm64-4cpu-8gb: github.com/cilium/tetragon/pkg/sensors/tracing: TestTraceKernelModule HOT 1
- I think that we currently cannot have a TracingPolicy and a TracingPolicyNamespaced with the same name.
- LSM `security_path_*` deletion kprobes can't resolve target dentry name HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tetragon.