Coder Social home page Coder Social logo

Comments (1)

kkourt avatar kkourt commented on August 12, 2024 1

Thanks @willfindlay. I think I know what this issue is here.

We need to wait for the pipes before we call cmd.Wait()

From: https://pkg.go.dev/os/exec#Cmd.StderrPipe

It is thus incorrect to call Wait before all reads from the pipe have completed.

So something like the code below, I think. Have a bunch of other things in flight now, but will do a PR on this next.
(other tests also need to be fixed).

@@ -47,14 +47,7 @@ func TestCopyFd(t *testing.T) {
        if err != nil {
                t.Fatal(err)
        }
-
-       go func() {
-               logOut(t, "stdout> ", testPipes.StdoutRd)
-       }()
-
-       go func() {
-               logOut(t, "stderr> ", testPipes.StderrRd)
-       }()
+       defer testPipes.Close()
 
        // makeSpecFile creates a new spec file bsed on the template, and the provided arguments
        makeSpecFile := func(pid string) string {
@@ -86,6 +79,9 @@ func TestCopyFd(t *testing.T) {
                t.Fatal(err)
        }
 
+       logWG := testPipes.ParseAndLogCmdOutput(t, nil, nil)
+       logWG.Wait()
+

from tetragon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.