Comments (3)
Since a unique repository is used to managed multiple different images, using the identifier (sha1) of a commit will force the update of every image every time one (or more) images need a tag bump.
That is why the first solution (used before renovate) was actually using the tree hash of the image's directory(sha256).
Renovate doesn't know how to sort SHA as stated in this github discussion renovatebot/renovate#23459
More informations on the way renovate reads SHA tags were found here : renovatebot/renovate#25849
Multiple approach have been tested so far :
Using latest tag in order to bypass the need for renovate to sort any SHA tag.
Unfortunately, and contrary to what discussion 23459 states, Renovate doesn't seem to be able to read latest tags (tested locally, message was the same as the SHAs error message but with latest).
Setup a proper semver mechanic would take a long time and add more maintenance to ensure the proper bumping of versions.
Fetching the last commit per directory using git log, and extract its timestamp could be the right way to go :
- The git log command, when given a specific directory in parameter, retrieve the last commit were changes were made in said directory.
This means that we can ensure different image versions same as used to be with git-tree. - Renovate easily sort versions from left to right, which means using a timestamp as a tag value would allow renovate to retrieve the latest version deployed with ease. (Tested locally and it worked fine)
- Few code would be needed to perform this action and would need the same amount of maintenance as the old solution.
from image-tools.
Had issue with auto-update of runtime and builder images in cilium/cilium, finally managed to fix those by changing the already existing workflows to update those in this PR : cilium/cilium#34372
from image-tools.
I think this issue can be closed? Thank you for the fix!
from image-tools.
Related Issues (20)
- image signing
- consider using cache
- automate updating `FROM` statements with new digests HOT 1
- turn `build-image.sh` into a high-level tool HOT 1
- push to quay.io as well as docker.io HOT 4
- include core shared libraries in all images
- rename repo to image-tools
- Add bazel to compilers image
- Arm64: clang error - unable to create target: No available targets are compatible with triple "bpf" HOT 2
- validate build logic on PR
- use full image names
- use buildx bake
- lookup commit ID based on tree hash
- test out GitHub registry HOT 3
- Failed to pull images for linux/arm/v7 HOT 1
- build images on PRs HOT 1
- Unknown flag: --builder with docker buildx
- missing iproute2 build dockerfile HOT 5
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image-tools.