Coder Social home page Coder Social logo

Comments (1)

stevengliebe avatar stevengliebe commented on June 22, 2024

Thank you for this suggestion. I will give it some consideration. I recommend people explicitly define which taxonomies and fields their theme will use so if a new one is added to the plugin, it is not automatically revealed to the theme users (since the theme likely won't support it right away).

http://churchthemes.com/guides/developer/church-theme-content/#recommended-usage

What now is this:

add_theme_support( 'church-theme-content' );

add_theme_support( 'ctc-sermons', array(
    'taxonomies' => array(
        'ctc_sermon_topic',
        'ctc_sermon_book',
        'ctc_sermon_series',
        'ctc_sermon_speaker',
        'ctc_sermon_tag',
    ),
    'fields' => array(
        '_ctc_sermon_has_full_text',
        '_ctc_sermon_video',
        '_ctc_sermon_audio',
        '_ctc_sermon_pdf',
    ),
    'field_overrides' => array()
) );

...

Might become something like:

add_theme_support( 
    'church-theme-content',
     array(
        'sermons' => array(
            'taxonomies' => array(
                'ctc_sermon_topic',
                'ctc_sermon_book',
                'ctc_sermon_series',
                'ctc_sermon_speaker',
                'ctc_sermon_tag',
            ),
            'fields' => array(
                '_ctc_sermon_has_full_text',
                '_ctc_sermon_video',
                '_ctc_sermon_audio',
                '_ctc_sermon_pdf',
            ),
            'field_overrides' => array()
        ),
        'events',
        'people',
        'locations'
    )
);

I would have to consider how to make a change like this backwards compatible.

My apologies for such a late response. I need to figure out how to get GitHub to email me when new issues are opened. For months I was thinking nobody had contributed yet. Just merged in the first pull request into the framework today, which felt great.

from church-theme-content.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.