Coder Social home page Coder Social logo

Comments (4)

chrysn avatar chrysn commented on June 22, 2024

that naming stems from the original txthings, which seems to implement some more generic twisted interface. one could argue that the METHOD verbs of both HTTP and CoAP are always uppercased, which forms a prevailing style, but on the other hand we don't have to care much about compatibility yet (no api-stable release has been made, my concern is mainly about doing changes in a way that allows library users to easily migrate, eg. with search/replace).

i'm willing to do that change, but would also accept a pull request; thanks for reporting.

from aiocoap.

aellwein avatar aellwein commented on June 22, 2024

No problem. Here is the pull request.

from aiocoap.

chrysn avatar chrysn commented on June 22, 2024

cherry-picked and done, thank you.

i've changed two minor things:

  • commit messages should have a short single-line description followed by an empty line. (i don't strictly follow the 50 chars limit, but the general formatting has good reasons.
  • use str(x) instead of x.__str__(), avoiding python internals

from aiocoap.

aellwein avatar aellwein commented on June 22, 2024

Sounds reasonable, thank you!

from aiocoap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.