Coder Social home page Coder Social logo

Comments (7)

HammadB avatar HammadB commented on July 24, 2024 1

In this, would you propose updating the api routes from collection_name to collection_uuid? I agree it is cumbersome to do again and again, and with good local clients - not necessary.

Yes I think so. We can also keep the old routes and wrap the logic somehow, creating new ones for uuid.

Solution space includes

  1. What we discussed above
  2. just cache it locally.
  3. Change our reads to filter on the name. Since we don't have an index currently on collection_uuid we could just change it. I don't think we should do that as we will want that soon.

from chroma.

levand avatar levand commented on July 24, 2024 1

So an observation: the current user-facing API doesn't expose the notion of an collection UUID at all, users interact with it solely in terms of its name.

In the (first version) of the refactored architecture, collections are associated 1:1 with Pulsar topics, which are namespaced by tenant, and have a string name (with similar but more flexible naming conventions to what topics have now.)

So IMO we can keep using the user-provided name as the primary key for now, and do away with the complexity of having an separate unique ID for a collection.

Regardless, I don't think this is urgent enough to address before the refactor lands (at which point the approach will change anyway).

from chroma.

jeffchuber avatar jeffchuber commented on July 24, 2024

In this, would you propose updating the api routes from collection_name to collection_uuid? I agree it is cumbersome to do again and again, and with good local clients - not necessary.

from chroma.

atroyn avatar atroyn commented on July 24, 2024

Saves a DB roundtrip, too

from chroma.

HammadB avatar HammadB commented on July 24, 2024

Saves a DB roundtrip, too

Yep

from chroma.

jeffchuber avatar jeffchuber commented on July 24, 2024

@levand correct me if im wrong, but the refactor should not affect this, since this is mostly about the plumbing between the backend and the frontend?

from chroma.

jeffchuber avatar jeffchuber commented on July 24, 2024

Thanks for the feedback! Let's close this for now and re-open it if/when the need arises.

from chroma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.