Comments (10)
chriswarren
commented on September 26, 2024
A fork for this has already been started.
In the meantime you can already set the gem to use V2 by setting config.version = "v2" in your initializer.
If you'd like to set it to be the default sooner, please fork the gem and submit a pull request, I'll gladly pull it in. I believe the V2 API is backwards compatible with V1, it just had new options. All that has to happen to switch the library to V2 by default should be changing https://github.com/zencoder/desk/blob/master/lib/desk/configuration.rb#L67.
from desk.
mbhnyc
commented on September 26, 2024
Just so it's clear, there's a fair amount that needs to be changed.
FYI, partial compatibility can be established for v2 just by adding
request.headers['Content-Type'] = 'application/json'
into request.rb line 49. I'll try to keep working along these lines if I have time...
Unfortunately, some V1 stuff seems to be broken as well, for example, an update_customer_email request returns:
Faraday::Error::ParsingError: 757: unexpected token at '<!DOCTYPE html>...
<title>Desk.com - Page Not Found (404)</title>
Followed by a complete 404 html page. SO! Fun ahead :)
from desk.
dougcole
commented on September 26, 2024
What's the status on this? @chriswarren you said a fork has been started, is this still accurate? If so is it available for testing anywhere? We need to upgrade soon - I'll dig in if nobody is working on it, but don't want to duplicate existing work...
from desk.
chriswarren
commented on September 26, 2024
We're still working on it, and are close to having something to release. Desk has pushed V1 EOL back to Feb 15, 2014. Current rewrite is at https://github.com/colinc/desk/tree/api-v2-rewrite, and will be merged in to this branch once we've finished doing some final testing.
from desk.
mbhnyc
commented on September 26, 2024
@chriswarren things are getting scary out here in Ruby land! How's the rewrite coming?
from desk.
colinc
commented on September 26, 2024
@mbhnyc Thanks for reminding me, I just submitted a pull request for my rewrite. We're using it in production and haven't had any problems (with the Ruby code anyways). The Desk.com API v2 still has a number of bugs that I know of (a few annoying, two critical). I reported some of them 6+ months ago but hopefully they'll be fixed before the Feb 15th cutoff.
from desk.
mbhnyc
commented on September 26, 2024
Oi, sounds like they need another delay!
from desk.
chriswarren
commented on September 26, 2024
I just published 1.0.0 to Rubygems, which includes all of @colinc's great work. Check it out, and if there are any issues let us know (or patch them and send a pull request).
from desk.
mbhnyc
commented on September 26, 2024
👍
from desk.
thomasbalsloev
commented on September 26, 2024
Fantastic! :) Great work!
from desk.
Related Issues (20)
- Copy-paste errors in ratelimit_remaining
- Faraday parsing errors even after #31 HOT 12
- Please update faraday dependency / conflicts with google oauth2 HOT 1
- gem "hashie" issue HOT 7
- Search case by order_no HOT 7
- collections only respond to each instead of all of Enumerable HOT 4
- Raise Desk-namespaced exceptions for other non-200 responses
- 422 error response not parsed correctly HOT 5
- Faraday::ParsingError: 757: unexpected token at 'Too Many Requests' HOT 1
- Desk.com gem ignores client config? HOT 2
- Desk.delete_case is not working HOT 3
- Logger does not log request and response body
- Document how to log request and response
- RuntimeError: missing dependency for FaradayMiddleware::Deashify: undefined method `type' for class `Hashie::Mash' HOT 9
- Incorrect from/reply_to address
- Configuration Issue
- Desk.insights_meta produces a 404 HOT 2
- Problem with the Thread.current in the Configuration HOT 1
- Bug when creating articles HOT 1
- Hashie fixed version giving conflicts HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desk.