christopherbignamini / varlist

VarList

varlist's Issues

real*X is a bug - and some things more in the vicinity

Fortran Standard is clearly stating that the kind numbering is arbitrary and implementation dependent. Best is to go with the basic Fortran types:

real8 as of today and the compilers which support this: double precision (is C interoperable with c_double)
real4 as of today and the compilers which support this: real (is C interoperable with c_float)

To get Fortran logical working at all you need to define logical always as logical(kind=c_bool) (you can as well use logical(c_bool), which I personally find nicer).

Create Readme

Could you please create a Readme describing the purpose of the project? Based on the repo title and looking at a few files it seems to be about passing lists of variables from Fortran to C++. If that is correct I would like to add it to the interoperability section of my list of Fortran codes on GitHub.

Debug access array function and remove it

VarList/varlist.h

Line 90 in e4ef0f8

void varlist_strcfi_accessArray(const VARLISTSTRCFI* i_varlist, CFI_cdesc_t* io_variable);

Fix dim array allocation management in copyToCFI_cdesc_t

VarList/CFICDesc.cpp

Line 27 in c5c8e1b

// TODO: here I assume that the passed CFI_cdesc_t reference is already completely allocated

Array low bound calculation

VarList/CFICDesc.cpp

Line 16 in 2ff12c4

m_dim.push_back(CFI_dim_t{i_cdesc_t.dim[i].lower_bound+1, i_cdesc_t.dim[i].extent, i_cdesc_t.dim[i].sm});

+1 is needed otherwise a 0 low bound array is stored, also if the original fortran array is a 1 low bound one