Comments (16)
Hmm, I'm not sure...
This complicates matters for users:
You are required to have a working Java compiler toolchain, the right ANTLR jar in your CLASSPATH and a matching Antlr-Python runtime...
P. S. : I've just disabled Appveyor regeneration.
from pya2l.
This complicates matters for users:
You are required to have a working Java compiler toolchain, the right ANTLR jar in your CLASSPATH and a matching Antlr-Python runtime...
Indeed. A possible solution would be to setup automatic building of wheels with every commit and add them to the pre-release page.
Unless I'm mistaken, the ANTRL Python run-time package is already required.
from pya2l.
Well, the automatic package build and upload to GH releases (and in the near future to Python package index) actually works -- source builds only, I still have to figure out why there are no wheels, but in this case (no C/C++ extensions) wheels are not really required.
from pya2l.
CLASSPATH seems to preferred:
https://stackoverflow.com/questions/41021963/how-to-install-antlr4
https://www.antlr.org
from pya2l.
I'm working on improving the way setup.py finds ANTLR. I'll include looking in CLASSPATH.
from pya2l.
There still two issues:
- build_py doesn't copy the Antlr artifacts to the now empty py3/ directory.
- build_py should also be triggered by the develop target, which is important for people working on the project.
from pya2l.
* build_py doesn't copy the Antlr artifacts to the now empty py3/ directory.
This is intended. Since python2 is no longer supported, I saw no reason to keep the py2/py3 distinction. build_py copies the artifacts directly into pya2l/.
* build_py should also be triggered by the develop target, which is important for people working on the project.
Fixed in #15.
By the way, did you intend to remove a2l_listener.py in your most recent commit? It seems kind of important...
from pya2l.
a2l_listener is back again...
Now I'm trying to figure out what's wrong with appveyor's CLASSPATH.
from pya2l.
You are going to need to add -L to the curl call when downloading ANTLR in appveyor.yml. https://www.antlr.org/download/antlr-4.8-complete.jar is a redirect, but without -L curl just downloads the html page instead of following it.
Edit: Or perhaps that's just curl on unix. Appveyor did seem to be working earlier.
I'm just as confused as you with regards to the environment variable, though. Could it be that coverage is opening a new shell? Environment variables set via set
are shell local.
from pya2l.
This could be a problem with subprocces, yes. I will replace the coverage stuff with a plain setup.py call.
from pya2l.
I tried some stuff in #17 and the only thing that worked for me was cmd /C "set "CLASSPATH=%APPVEYOR_BUILD_FOLDER%\antlr-4.8-complete.jar" && %PYTHON%\python.exe setup.py test"
It still fails because setup.py test
currently does not run ANTLR automatically. I'm thinking to fix that with a unit test which will both cover the AntlrAutogen class and also creates Lexers and Parsers as a side effect.
from pya2l.
I've found a working makeshift solution, but now there are import errors:
https://ci.appveyor.com/project/christoph2/pya2l/builds/31578524/job/7g7gmji3s3l4wps5
from pya2l.
That's because the test isn't generating lexers and parsers. I've fixed it locally, but I'm currently out of office. I'll make a pull request in a few hours.
Can you merge #16 in the meantime?
from pya2l.
AppVeyor almost works now. Coveralls just can't find the repo token for some reason?
Edit: Probably because of this: https://help.appveyor.com/discussions/problems/5873-coveralls-environment-variable-not-always-working#comment_41725435
from pya2l.
I would merge, but unfortunately there are conflicts, so rebase and merge functionality is disabled.
from pya2l.
Are you sure? On my end github says "This branch has no conflicts with the base branch". I'll try to do a rebase.
Edit: Rebase done, try it now.
from pya2l.
Related Issues (19)
- Create dynamic AML parser. HOT 1
- A2l.g4 is not match the code in py3 folder
- Use pyA2L for export to excel HOT 3
- Logger shall output filename and linenumber.
- Parser fails on multidimensional arrays HOT 3
- Parse xcp_on_can HOT 5
- tool cannot create db when long names are having multiple quotes
- Configure A2L parser from JSON file.
- Autodetection of a2l file encoding is not accurate HOT 4
- Token recognition error
- Implement A2L include mechanism. HOT 1
- Message type for asap version
- Parse an xml/arxml to create intermidiate A2L HOT 1
- Taking signals from A2L file
- A2L parsing error due to the preprocessing the multipline comments HOT 1
- ModuleNotFoundError: No module named 'pya2l.py3' HOT 2
- Documentation for using the A2L packages HOT 5
- python setup.py install failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pya2l.