Coder Social home page Coder Social logo

Comments (4)

FinnEngenhorst avatar FinnEngenhorst commented on July 23, 2024

Thanks you saved me some time

from archtitus.

ChrisTitusTech avatar ChrisTitusTech commented on July 23, 2024

AWESOME! never seen this approach before, committed it to test branch along with some other fixes.

from archtitus.

ChrisTitusTech avatar ChrisTitusTech commented on July 23, 2024

Thank you so much, this is now live and works great with @nlinaje fix.

from archtitus.

nlinaje avatar nlinaje commented on July 23, 2024

You are welcome! I really like the script, though I still have some problems with it due to be testing it in a VM with low resources.
I was wondering if this change fixes the problem in the whole process. After looking at it, it seems good, but the following code seems somewhat strange (script 1-setup.sh which is started by archtitus.sh as user root):

echo "username=$username" >> "${HOME}/ArchTitus/install.con"
I understand that "$HOME" refers to /root. The first time I read it, I thought HOME should be /home/, but then I realize that I was doing a false supposition. I find it a little confusing while reading it.

The next command is an if clause checking if we are root:

if [ $(whoami) = "root" ]; then
   xxx
   cp -R /root/ArchTitus /home/$username
   xxx
fi

The copy command permits that the original problem of this issue does not propagate to the next scripts 👍 But, why do you check if user is root? and why do you use here "/root/ArchTitus" and before you have used "$HOME"?

from archtitus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.