Coder Social home page Coder Social logo

Minimum python version is 3.10 about canopen HOT 3 CLOSED

sveinse avatar sveinse commented on August 22, 2024
Minimum python version is 3.10

from canopen.

Comments (3)

acolomb avatar acolomb commented on August 22, 2024

That is unfortunate, as it is really unnecessary to bump the Python version requirement just because of this usage. And as far as I found, there is actually only one instance of it, here:

def __init__(self, bus: can.BusABC | None = None):

Did you see any other occurrences?

I'd prefer to fix that instead. As much as I like the improved type annotation features, as a library we should stay conservative and adopt the new standard only when it brings enough benefit or is used more consistently throughout the code.

from canopen.

sveinse avatar sveinse commented on August 22, 2024

I have checked that with the patch of canopen/network.py

-    def __init__(self, bus: can.BusABC | None = None):
+    def __init__(self, bus: Optional[can.BusABC] = None):

It will work fine all versions down to python 3.6.

from canopen.

acolomb avatar acolomb commented on August 22, 2024

Thanks for checking. The change was done in b55ce5c.

from canopen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.