Upgrade Cinder for compatibility with mkdocs 0.17 about cinder

[mmatyas]

+1

Here are the deprecation warnings I get with mkdocs 0.16.3:

WARNING -  Template variable warning: 'copyright' is being deprecated and will not be available in a future version. Use 'config.copyright' instead. 
WARNING -  Template variable warning: 'favicon' is being deprecated and will not be available in a future version. Use '{{ base_url }}/img/favicon.ico' instead. 
WARNING -  Template variable warning: 'current_page' is being deprecated and will not be available in a future version. Use 'page' instead. 
WARNING -  Template variable warning: 'site_name' is being deprecated and will not be available in a future version. Use 'config.site_name' instead. 
WARNING -  Template variable warning: 'page_title' is being deprecated and will not be available in a future version. Use 'page.title' instead. 
WARNING -  Template variable warning: 'page_description' is being deprecated and will not be available in a future version. Use 'config.site_description' instead. 
WARNING -  Template variable warning: 'canonical_url' is being deprecated and will not be available in a future version. Use 'page.canonical_url' instead. 
WARNING -  Template variable warning: 'site_author' is being deprecated and will not be available in a future version. Use 'config.site_author' instead. 
WARNING -  Template variable warning: 'next_page' is being deprecated and will not be available in a future version. Use 'page.next_page' instead. 
WARNING -  Template variable warning: 'repo_url' is being deprecated and will not be available in a future version. Use 'config.repo_url' instead. 
WARNING -  Template variable warning: 'previous_page' is being deprecated and will not be available in a future version. Use 'page.previous_page' instead. 
WARNING -  Template variable warning: 'include_next_prev' is being deprecated and will not be available in a future version. Use '(page.next_page or page.previous_page)' instead. 
WARNING -  Template variable warning: 'repo_name' is being deprecated and will not be available in a future version. Use 'config.repo_name' instead. 
WARNING -  Template variable warning: 'include_nav' is being deprecated and will not be available in a future version. Use 'nav|length>1' instead. 
WARNING -  Template variable warning: 'homepage_url' is being deprecated and will not be available in a future version. Use 'nav.homepage.url' instead. 
WARNING -  Template variable warning: 'toc' is being deprecated and will not be available in a future version. Use 'page.toc' instead. 
WARNING -  Template variable warning: 'content' is being deprecated and will not be available in a future version. Use 'page.content' instead. 
WARNING -  Template variable warning: 'meta' is being deprecated and will not be available in a future version. Use 'page.meta' instead.
WARNING -  Your theme does not appear to contain a 'main.html' template. The 'base.html' template was used instead, which is deprecated. Update your theme so that the primary entry point is 'main.html'. 

And the hard error with 0.17:

ERROR   -  Error building page index.md
Traceback (most recent call last):
  File "/home/mmatyas/.local/bin/mkdocs", line 11, in <module>
    sys.exit(cli())
  [...]
  File "/home/mmatyas/.local/lib/python2.7/site-packages/jinja2/loaders.py", line 187, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: main.html

Here's the mkdocs changelog: http://www.mkdocs.org/about/release-notes/

[chrissimpkins]

@mmatyas @trevor-white-ck thank you both. will get the PR merged when it is available.

[trevorwh]

@chrissimpkins just a heads up, I'll submit this PR from my personal account (not my work account). You'll see it in the next couple hours.

[trevorwh]

@chrissimpkins we are good to go!

[chrissimpkins]

I have been grossly negligent with this project and am trying to get to updates every six months or so. There are a number of outstanding PR's that I need to tackle at some point.

Definitely would be willing to merge a straightforward PR that does not involve a great deal of source review at this stage.

I haven't kept up with mkdocs changes as of v0.17. What should I be expecting for changes?

[ketozhang]

That's quite unfortunate. I find Cinder the best fit for what I need. It's so clean and nice looking. Can't help you out much but just a +1 to this suggestion.

[chrissimpkins]

@trevor-white-ck can you submit the PR that you proposed or point me to documentation on how mkdocs was modified that breaks this theme?

[chrissimpkins]

@ketozhang if we don’t get a response to the above request can i ask you to submit the error message that you receive when you attempt to build? Thanks. I intend to fix this so that it is usable.

[trevor-white-ck]

I have a patch ready for this already. I will cut a PR for the upgrade to 0.17 today or tomorrow. @chrissimpkins

[chrissimpkins]

@trevor-white-ck Something that you are still willing to push for us Trevor?

[trevor-white-ck]

Yep will push a pr this morning! Sorry for the delay.

On Wed, Jan 3, 2018 at 5:46 AM Chris Simpkins ***@***.***> wrote: @trevor-white-ck <https://github.com/trevor-white-ck> Something that you are still willing to push for us Trevor? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Abi5NyAJWpDMSQNMI3EEHTti11HeFFWdks5tG4SWgaJpZM4Qq4Mw> .

-- *Trevor White | Senior Engineering Manager | Credit Karma, Inc.* P: 415.510.5116 <javascript:void(0);> [email protected] | www.creditkarma.com <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.creditkarma.com_&d=CwMGaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=BRTlPldwLWZMBPbpV4ibmQ&m=OFfeOhjbFxpFot7S7QtbDzSGLVQe8XZ1hrHy4_VmmvE&s=i9bhSE5S-uADIKaC8FLHjHeuOauYD6dK4v6NRqH4Ncs&e=>

[chrissimpkins]

No worries! I accept all of the blame for the delay here. You are helping. :)

[chrissimpkins]

@trevorwh thank you!!

[chrissimpkins]

@trevorwh and no rush! Just following up with you earlier. If you didn't intend to submit it, I was going to try to get it done.

[chrissimpkins]

Thanks so much Trevor!!

Trevor's fixes available in v0.10.0

Available on PyPI:

pip install --upgrade mkdocs-cinder