Comments (7)
Awesome!
Let me see if I can carve out some time this week ...
from ember-freestyle.
First, love the addon, and awesome EmberConf talk! 😄
To simplify the annotation technique, are you aiming at keeping the components but changing public API, or are you thinking of removing/merging them?
I can see that freestyle-note
and freestyle-annotation
are used as public components to build the guide but freestyle-notes
seems to be used privately to implement freestyle-note
.
If this is true, I am wondering if we could try to merge the behavior of freestyle-note
and freestyle-annotation
into one component.
This component could be either configurable (with positional parameters?) or smart enough to know the type of annotation (markdown or HTML) to produce based on context and/or content.
I know this is pretty vague, I'm going to find some time and try put together a quick PR.
Any comments or pointers as to where you want to go with it would be really helpful
Thanks!
--Miguel
from ember-freestyle.
@migbar Thanks and thanks! These are early days, so I think we should remove/merge components to arrive at something simple.
Your outlined approach sounds good at first glance. As we dig in, we should document the purpose and usage guidelines for each of the (hopefully two) components.
As you're able to start digging into this, I will start digging into #48 as it's somewhat related. We may as well aim for one compatible set of breaking changes in an upcoming release.
from ember-freestyle.
Hi, love freestyle, we use it on every project. This is currently a bit of a pain on our end, people frequently mess up the note slug. Unfortunately, the slug lives on the same level as usage
, making it difficult to just implement this using contextual components. What are your guys thoughts on a redesign or iterative change to make this easier to work with? I think it would be nice to have something that just works for the simple use case, but still flexible to provide overrides for other uses that people are also doing.
from ember-freestyle.
This would be addressed by #340.
from ember-freestyle.
#357 has simplified this somewhat by removing freestyle-note and consolidating on freestyle-annotation. The real fix will be via #340 though.
from ember-freestyle.
Can we close this one? I think the original issue (having 3 separate components) is now resolved? I created #613 to completely get rid of the remaining freestyle-note
component.
from ember-freestyle.
Related Issues (20)
- Style loading issues with freestyle page snapshot using @percy/ember HOT 6
- `ember-canary` scenario fails HOT 1
- Drop support for Node.js v10
- Remove `pick` helper? HOT 3
- Revert allowing the `ember-beta` scenario to fail
- Test against Embroider
- Remove the use of `ember-cli-sass-lint` HOT 1
- Deprecate `FreestyleShowdownContent` component
- Remove `freestyle-note` component from `app` folder HOT 1
- Update `ember-auto-import`
- Remove resolutions / unpin dependencies
- Use `exclude` option instead of `blacklist` option in README once available
- Migrate to Glimmer components
- Don't publish `.husky` folder
- Add support for glint HOT 2
- Migrate to V2 addon HOT 1
- UI / UX Improvements HOT 1
- Remove use of `EmptyObject` type HOT 1
- Add optional Freestyle::Usage section to document/explore CSS variables
- Breaks under `ember-cli` v5 (uses `ember-cli-preprocess-registry` v5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-freestyle.