Needs change in table definition about data-models

[rosequeen442]

Thanks @parthdivekar!

The PCORnet V3 specification fails to specify a size for these fields (noting them only as "Text(x)". So I don't think we should change the model definition files, but instead alter the DDL generation to insert a large default size value. What do you think?

[rosequeen442]

I'm going to go ahead and move this to the chop-dbhi/data-models-sqlalchemy and implement the default size when generating Oracle DDL, as I suggested above.

[parthdivekar]

Aaron

That’s fine. Since these are the fields to store RAW source data you can set it to varchar2(4000).

Hope this helps.

Parth

From: Aaron Browne [mailto:[email protected]]
Sent: Wednesday, July 08, 2015 4:41 PM
To: chop-dbhi/data-models
Cc: Divekar, Parth
Subject: Re: [data-models] Needs change in table definition (#78)

I'm going to go ahead and move this to the chop-dbhi/data-models-sqlalchemy and implement the default size when generating Oracle DDL, as I suggested above.

—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_chop-2Ddbhi_data-2Dmodels_issues_78-23issuecomment-2D119725536&d=BQMCaQ&c=P0c35rBvlN7D8BNx7kSJTg&r=51BgVjzesEXW9OlDtRO3QudXA4b7ZKbVCRNjVzXkQg0&m=onXjsNidPJZ1zaC7-bApRq4TxllunoqDL6qAnueqZ58&s=AFrxZEQEl-qdaFaUeQ1lljg1X-391cF_YPyM00KhmJM&e=.

[rosequeen442]

Just saw this, on my first pass I set to 255 CHAR, but if you think 4000 will be required, we can definitely do that. Please follow progress and post additional comments at chop-dbhi/data-models-sqlalchemy#4