Missing TiledProperty types about tiled-types

[Chnapy]

Fix published, please upgrade to 1.3.0 👍

[Chnapy]

I don't think it's possible, because of how array filter works.
Let me show you a basic example:

type Sample = { type: 'int'; a: 1 } | { type: 'foo'; b: 7 };

const sample: Sample = null as any;

if(sample.type === 'int') {
    sample.a;    // works
}

const list: Sample[] = [sample];

list
    .filter((p) => p.type === "int")
    .map(p => p.a)  // error, because at this stage we don't know p.type value

Unlike the if statement, array filter do not "keep" the type inference.
The proper way I know in your case is doing like that:

const { shadowGid, shadowX, shadowY, tintcolor, opacity } = mergeAll(
      properties
        .filter((p): p is TiledPropertyAbstract<number, 'int'> => p.type === "int")
        .map((p) => ({ [p.name]: p.value }))
    );

It's still a cast tho.

[Chnapy]

Hi,
Thank you for your feedback, I'll try to do required changes very soon.

For the record, after quick investigation I got this result:

These properties

give these JSON props

[
        {
         "name":"azerty",
         "type":"color",
         "value":"#ffff5500"
        }, 
        {
         "name":"foo",
         "type":"string",
         "value":"bar"
        }, 
        {
         "name":"tata",
         "type":"float",
         "value":8.89
        }, 
        {
         "name":"titi",
         "type":"file",
         "value":"Links.txt"
        }, 
        {
         "name":"toto",
         "type":"bool",
         "value":true
        }, 
        {
         "name":"tutu",
         "type":"int",
         "value":8
        }, 
        {
         "name":"tyty",
         "type":"object",
         "value":7
        }
]

[AdrienLemaire]

@Chnapy thank you for that!

I have another question in regards to this type.

Given the code:

    const { shadowGid, shadowX, shadowY, tintcolor, opacity } = mergeAll(
      properties
        .filter((p) => p.type === "int")
        .map((p) => ({ [p.name]: p.value }))
    );

I'd like all my destructured variables to be of type number | undefined, but I'm seeing string | number | boolean | undefined:

Do you think the type can be updated to support that case ?

For now, I'll cast the type

    const { shadowGid, shadowX, shadowY, tintcolor, opacity } = mergeAll(
      properties
        .filter((p) => p.type === "int")
        .map((p) => ({ [p.name]: p.value }))
    ) as Record<string, number>;