Comments (3)
On every change of the file, the diagnostics are updated. It seems like your editor does not coalesce these ?
There are also two mechanisms diagnostics can be received:
- the default by Verible is to publish new diagnostics whenever some change happens in the file (
textDocument/publishDiagnostics
) - It also seems that your editor is requesting diagnostics independently (
textDocument/diagnostic
), so maybe this is where things get merged and show up multiple times ? Is the"disabledFeatures"
configuration switching the explicit request off ?
So things do look like they work as intended, just that the editor does not remove the duplicates.
I'll have a look if it is possible by the editor to request not auto-publishing diagnostics when it actually does the request by itself (maybe there is a setting the editor can send to the language server).
But you should probably also file an issue with your editors' language server implementation to make sure they coalesce the identical diagnostic messages properly or ignore diagnostic notifications when they already request
from verible.
The "disabledFeatures"
configuration doesn't switch the explicit request off. I think it just diabled one of the messages from diaplaing.
I will file an issue with the language server implementation plugin as well.
from verible.
Is the "disabledFeatures" configuration switching the explicit request off ?
The disabledFeatures
made coc.nvim ignore publishDiagnostics one.
verible server files the capabilities with diagnosticProvider
, coc.nvim will use pull mode to request to server for diagnostics.
I think the server shouldn't use both publishDiagnostics and diagnosticProvider at the same time, or use publishDiagnostics on document didOpen only, and pull mode for onSave and onChange.
from verible.
Related Issues (20)
- verible-verilog-syntax does not fully support `protect directive
- VSCode can't set binary path in windows
- Long `localparam` lines are not formatted HOT 1
- Return type using `type(...)` throws syntax error
- verible-verilog-obfuscate crashes when program has pragma directive
- [proper-parameter-declaration] parameter vs localparam in packages HOT 4
- [unpacked-dimensions-range-ordering] - configuration
- nix package for mac not available
- Parser rejects streaming operators that use the "with" clause
- All features, can add the option to accept the contents of the file without having to pass in one file at a time. HOT 1
- automatically comment preprocessor conditionals
- linter cannot find macro defined in a different file HOT 3
- VSCode - Generate and maintain verible.filelist
- verible.filelist empty file exception
- Feature Request: do not add spaces around logical keywords
- verible-verilog-syntax crashing HOT 5
- Verible formatter fails when third line of port list is blank HOT 1
- What is the current state of spaces in the preprocessor
- Formatter unable to recognize class instantiation with parameter override inside a struct/union
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verible.