Linguist Support, TextMate Grammar Support about firrtl-spec

[seldridge]

Fixed with github-linguist/linguist#6848.

[seldridge]

By my count there are ~8k code samples on GitHub as gleaned from the following search:

https://github.com/search?p=10&q=extension%3Afir+NOT+flang+NOT+func+NOT+%22RUN%22+-user%3AKosinskiLab+-user%3Alukezya+-user%3ALourencoPonces+-user%3ALesible+-user%3Ajoaomiguelcaldeira&type=Code

This is slightly complicated as .fir shares a file extension with FLANG IR.

[dtzSiFive]

This is slightly complicated as .fir shares a file extension with FLANG IR.

In theory, all FIRRTL must have a version identifier after that was introduced, and so maybe that can be checked to differentiate the two? (if not just 'are the first (non-whitespace?) characters "FIRRTL"?'). Just a thought.

[seldridge]

Checking for the version string / FIRRTL in it would enable a trivial heuristic to differentiate the two. Great thinking.

[ekiwi]

Checking for the version string / FIRRTL in it would enable a trivial heuristic to differentiate the two. Great thinking.

Wouldn't all older FIRRTL files start with circuit? Then if you check for FIRRTL or circuit your heuristic should work for virtually all firrtl files.

[seldridge]

Checking for FIRRTL or circuit sounds great. 👍