Swift package manager support.. about chtcollectionviewwaterfalllayout

[chiahsien]

I’ve pushed a new tag, please help to check if it works.

[lvnkmn]

And I've implemented this in my fork, I will create a pull request shortly.

[lvnkmn]

Super nice that this is merged. Looking forward to a release of this.

[lvnkmn]

@chiahsien, can you create a release using this code? Until then SPM cannot be used with version numbers.

[chiahsien]

@lvnkmn Please send me the PR. I don’t do iOS for a while and i need support from community. 😃

[ApolloZhu]

@chiahsien I think only you as the project owner (or another collaborator who has the permission) can do this. You have created releases on GitHub before (like this one). But just in case, this shows how you can create a new release

[lvnkmn]

@ApolloZhu is right.

To release a version for SPM, all you have to do is (considering the development branch is stable and contains everything that needs to be released). ->

1. Merge development into master
2. Tag it with 0.10.0 considering there's no breaking changes or 1.0.0 when there's been breaking changes since last release.
3. Make sure you push the changes and tags.

To also make that release available to cocoapods, you'd have to also update the podspec with the new version and upload to their specs repo like explained here (Submitting Open Source Code).

[chiahsien]

I understand. But since this project is in maintenance mode, I think it'd be better to follow latest master branch instead of certain tag.

I'm happy to merge PR into master, but I'm lazy to release a new tag and update CocoaPods/SPM, and sometimes it doesn't worth it to release a new tag for a minor patch.

How do you think? Any suggestions?

[lvnkmn]

Ok. What I could do, is cherry pick the SPM commit and create a PR which you can merge into master.

In order to get some benefit out of this, is to tag this with a += 0.0.1 version so the new version would be 0.9.8

Eventhough for github this would count as a release, there would be no added benefit of creating a cocoapods release for it, so you can skip that for this one. SPM users would be happy though. Every release after that would just work for SPM with no added work.

Sounds reasonable?

[lvnkmn]

Or you could do the cherry pick into master + tag of course 🙂

[lvnkmn]

Thanks. Will let you know. First thing tomorrow morning.

[lvnkmn]

It works for me. So far no issues. Will close this. Thanks for the work!