Feature request: Command line read from URL about gcviewer

[chewiebug]

Hi Chris

I have never tested this functionality since it was built in before I
started to improve GCViewer. So it might be that I broke something
there. The code opening files from URLs should be the same if open from
GUI or commandline.

What error message do you get? Does your file open when you use the GUI?
Why do you replace '' with '/'? '' should never be part of a URL.

Regards, Jörg

[ChrisHZ]

Hi, When I try it without my change I get an occasional hang (something to do with user preferences) and the last time it tried to load the URL from the current directory so in this case failed to read file C:\MemoryApps\http:\localhost:8080\LastGC.log

Looking at the code I couldn't see it working it seemed to just pass the argument to the method expecting a file name.

With the change I have it working though I got an occasional fail to read the file (my jnlp passes a null argument) (it may be a webstart bug as there was one reported around these lines though I thought it fixed), so I have now changed to passing and reading a system property from within the JNLP to gcviewer and that works every time.

I still am investigating an issue where I have an occasional issue where it fails to read user preferences and null pointers on loading recentURLs, I've changed the code to just empty string if it can't load from the file rather than crash and that works fine.

My use case is as part of my test results I have a web page of GC logs, I previously had the option to copy the link as an URL into gc viewer manually which does work but it was suggested if I could web start gcviewer and pass the URL requested in that would be nicer and I do have it working in principle.

thanks for the reply

Chris

PS I needed the replace but that may just have been with the way I was testing, I don't need that replace in real world usage.

[chewiebug]

Hi Chris,

Ok, I have (finally) found the place in the code you are pointing at. It indeed won't work with URLs - I think it should so I marked this issue a bug.

You seem to have found a second issue with those occasional hangs / NullPointerExceptions. Does it occur when there is no gcviewer.properties file available? Is there a way to reproduce this hang / NPE?

Regards, Jörg

[ChrisHZ]

Hi,

With regard to the NPE , I suspect its how I was using it, I appear to have corrupted the gcviewer.properties with the URLS I have saved (recent URLS). So when it loadPreferences it loads the file but mis interprets some of my recent urls as null some how .

In the gcviewer code in RecentURLsMode.java URLSet createSortedFileStrings this fixes the issue fileStrings[i] = (urls[i] != null) ? urls[i].toString() : ""; I'd rather it lost my recent urls than crashed.

I suspect its something to do with my use case and I may be able to clean up my URLs (escape remove some parameters) to get round it (its had no trouble using the URL to read the file, just this preference loading bit when you stop and come back into gcviewer).

With regard to the parameter I am still using my change to a system property for the filename as webstart has not been reliable for me in passing a command line parameter, I am, still investigating it but I have seen accounts of others with the same issue.

[ChrisHZ]

Sorry didn't mean the close .. lol

[chewiebug]

Hi Chris,

I have pushed fixes to support URLs from the command line and prevention of the NPE when gcviewer.properties contains corrupt entries.

Does it now work for you?

Regards, Jörg

[ChrisHZ]

Hi,

Thanks for the effort.I'm testing now and will get back to you.

Chris

[ChrisHZ]

Hi,

Just to confirm I have been using the latest version for a couple of days without issue.

Chris

[chewiebug]

Hi Chris,

Thank you very much for reporting and testing!

Regards, Jörg