Coder Social home page Coder Social logo

Comments (6)

ecki avatar ecki commented on July 2, 2024

In this branch I have a prelimiary fix, it will parse the numbers as longs and it ignores the SAP parser exception with a different (language independent) method. However I think both is not the final version. The chart produced from above logfile does also not look right.

https://github.com/ecki/GCViewer/tree/topic-j9logfix

from gcviewer.

chewiebug avatar chewiebug commented on July 2, 2024

Now at least something is displayed. Thanks for looking into this problem.

I agree with you, that the chart does not look right. GCViewer assumes,
that all parsed events were FULL GCs. That is probably not right. The
README https://github.com/chewiebug/GCViewer/blob/master/README file
mentions, that the IBM logfiles contain much more information than is
parsed. IBM GMCV
http://www.ibm.com/developerworks/java/jdk/tools/gcmv/ is much better
in this case.

Regards, Jörg

Am 11.10.2012 03:50, schrieb Bernd:

In this branch I have a prelimiary fix, it will parse the numbers as
longs and it ignores the SAP parser exception with a different
(language independent) method. However I think both is not the final
version. The chart produced from above logfile does also not look right.

https://github.com/ecki/GCViewer/tree/topic-j9logfix


Reply to this email directly or view it on GitHub
#40 (comment).

from gcviewer.

ecki avatar ecki commented on July 2, 2024

Yes there is also a comment in the code that it only works for one policy (only looking at the allocation failure events). I try to work on that some more as I like the gcviewer statistics more than the GCMV (especially since it is somewhat only a reporting tool in ISA anymore).

from gcviewer.

chewiebug avatar chewiebug commented on July 2, 2024

Hi Bernd,

May I merge your preliminary fix? There is an increasing number of users who will profit from it.

Regards, Jörg

from gcviewer.

ecki avatar ecki commented on July 2, 2024

I have rebased my topic-j9fix, but I think the changes to LongData in the above commit from @sfraser looks better (I somewhat not sure where that commit was commited... )

from gcviewer.

chewiebug avatar chewiebug commented on July 2, 2024

I have pushed a fix based on your branch to allow those large heap numbers including correct conversion to KB when storing the event data in a GCEvent class. While coding the fix I finally understood, why @sfraser's commit looked better to you - I believe that the main confusion was centered around IBMs usage of Bytes in the log file while GCViewer stores KB in it's data model.

I close this issue since I believe that the problem for which you opened the issue is fixed now. The IBM logs still contain much more information than GCViewer can parse. Please open another issue if you work on improving GCViewers level of details that is parsed from one of those logs.

As always: If the fix doesn't solve the issue, please reopen it.

Regards, Jörg

from gcviewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.