Searching is Broken about chef-zero

[jkeiser]

Hmm, I haven't got a repro here. I have hashie-2.0.5 too. Can you try this quick to rule out an environment difference?

1. git clone chef-zero && cd playground
2. chef-zero -p 4000
3. knife upload nodes
4. knife search node name:blah

Expected results: 1 items found

Can you tell me what happens if you do this? (3+4 are from the same directory)

I tried the procedure with a downloaded node too, with no issue, but this will at least confirm that it's the node itself that is triggering the bug. If that's the case, it will help me a lot if you can send me a (possibly sanitized version of) the node json. Thanks!

[andrewgross]

Will do, was poking around Chef-Pedant and my issue should be covered, I'll dig in to see if I can find where it is wrong.

[jkeiser]

p.s. you need the latest knife-essentials for the above to work:

gem uninstall -a knife-essentials; gem install knife-essentials

[andrewgross]

Using Knife (or cURL) seems to work properly with the steps you gave. I will play around a bit more with Ridley and my data to see if I can pin it down.

[andrewgross]

Definitely something related to the data being put in place, but somehow just for search.

I uploaded my custom node info to the same server I had already verified was working.

Works with a proper response:

/search
/nodes
/nodes/my_custom_node

Fails:

/search/node

I will see if I can upload the data using knife instead of ridley to different effect, otherwise ill start diving in to the node data itself to see if I can pinpoint the issue.

[andrewgross]

Just ruled out ridley, going to dissect node data.

[jkeiser]

Thanks! I will also be happy to help debug if you can send me node data (though I'm in and out tonight). The node data I've uploaded doesn't do it.

It's entirely possible for something about your node data to be special. Given the error you're getting, I'm wondering if your data contains a data type that isn't in usual files. Maybe a number? A null? A boolean?

[jkeiser]

I just tried those and it didn't work. BTW, looking at the code this has something to do with a "normal" attribute (an attribute under the "normal" key). Possibly one that conflicts with a "default" attribute, but I'm guessing not. If you get rid of all automatic and override attributes from the node file, this should still repro. Then maybe try getting rid of default attributes from the node file, and see if it still repros.

Or send it to me and I'll happily slice and dice. I can understand not wanting to if there is sensitive data though!

Thanks tons for filing a bug, hopefully we can smash through this so you can continue with life :)

[andrewgross]

It works if I strip out the "normal" section of the node info. Here is the normal and default data (sanitized, but it still fails even after sanitization).

Normal Data: https://gist.github.com/andrewgross/aeaf3d0ef138b2565a40
Default Data: https://gist.github.com/andrewgross/9ae5104d6a6f8cd1d419

[jkeiser]

Yep, it only fails if you have BOTH the default and normal. Something is weird in the deep merge. Minimizing.

[jkeiser]

Here's the minimal repro:

{
"chef_type": "node",
"json_class": "Chef::Node",
"name": "blah",
"chef_environment": "_default",
"run_list": [],
"default": {
"expected_nodes": 1
},
"normal": {
"expected_nodes": 1
}
}

[jkeiser]

Appears to be a bug in Hashie. I can repro with this:

require 'hashie'

class Hash
include Hashie::Extensions::DeepMerge
end

{ x: 1 }.deep_merge({ x: 1})

[andrewgross]

Nice. Here is 'why'

http://stackoverflow.com/questions/13962147/why-cant-singleton-methods-be-defined-on-symbols-or-fixnums

In Hashie they are dumping the Hashie Deep Merge class in to the Hash that is passed in:

https://github.com/intridea/hashie/blob/master/lib/hashie/extensions/deep_merge.rb

However, it look's like the logic is failing and trying to dump this in to a Fixnum when they use the notation

(class << (tv = self[k]); self; end).send :include, Hashie::Extensions::DeepMerge

[jkeiser]

Yep. I've filed a bug against Hashie (hashie/hashie#99), but I've just copied Chef's deep_merge into chef-zero and will check in a fix shortly. Thanks tons :)

[andrewgross]

Awesome, thanks!

[jkeiser]

Version 1.2.1 released with fix. Let me know if it resolves!

[andrewgross]

Works like a charm, thanks @jkeiser