Colorized output and search shows ANSI Escape Sequences about cheat

[chrisallenlane]

I noticed this as well last night.

What pager are you using? I noticed that if I'm using less it works fine. Otherwise, I get an error if I have no pager configured. Is that what you're seeing as well?

Thanks for your help once more 🙂

[chrisallenlane]

This is being caused by the code that underlines the cheatsheet titles.

Now that I'm looking at this with fresh eyes, I don't like the underlining anyway. It adds too much visual noise to the results. I'm just going to rip it out.

[chrisallenlane]

@vaporup, this should be resolved in the 4.2.7 release:

https://github.com/cheat/cheat/releases/tag/4.2.7

Please let me know if that works for you. Thanks.

[chrisallenlane]

Oh, and one note about this one:

cheat -c ls

-c is short for --colorize, so it's always going to produce colorized output no matter what. That first example thus is expected behavior.

The cheat -s ls example was a bug, however, and should now be resolved with the newest release.

[vaporup]

Well,
I still get ANSI sequences with -c but no colors

[chrisallenlane]

@vaporup, oh, I see. I (partially) misunderstood the nature of the problem.

Yeah, it looks like if I disable the pager, I also get ANSI codes without colors. I'll take a second look at this. Thanks.

[chrisallenlane]

@vaporup, please try 4.3.0 and see if that solves the problem for you:

https://github.com/cheat/cheat/releases/tag/4.3.0

Note that cheat handles pagers somewhat differently now. It only reads pager configs from the config file, and no longer searches for pagers during runtime.

I don't think you were using a pager anyway (and you were thus able to identify this problem), but if you were, you may need to modify your config file.

Thanks again.

[vaporup]

The Escape sequences are gone but I don't get colored output using -c

[chrisallenlane]

@vaporup, please paste the contents of your cheat config file in this thread so I can take a look. Thanks.

[vaporup]

I always delete ~/.config/cheat when testing a new release, so it is the default config which is created on first run

[chrisallenlane]

Thanks again, @vaporup

I was able to reproduce the problem. Please try the 4.3.1 release:
https://github.com/cheat/cheat/releases/tag/4.3.1

As far as I can tell, this finally solves the problem. I'll optimistically close this ticket, but please let me know if this is still broken for you. Thanks.

[vaporup]

Looks good now :-)

[chrisallenlane]

Great to hear. Thanks, @vaporup 👍