Coder Social home page Coder Social logo

Comments (5)

charpeni avatar charpeni commented on May 18, 2024 1

Thanks for flagging this @donavon, I've been able to track this down.

whatwg-url needs punycode and we didn't catch this earlier because punycode is required by React Native's default dependencies and hoisted from eslint and jest.

I'll add punycode as a loose dependency of whatwg-url-without-unicode, then update this library.

from react-native-url-polyfill.

donavon avatar donavon commented on May 18, 2024

I've installed the package punycode and that seems to have solved the problem. If punycode is a requirement, should it not be listed in dependencies?

from react-native-url-polyfill.

charpeni avatar charpeni commented on May 18, 2024

Hey @donavon,

Thanks for reaching out!

Which version of Expo are you using? Do you mind sharing your package.json?

from react-native-url-polyfill.

donavon avatar donavon commented on May 18, 2024

It's the latest version and my project is a small test app built using expo init

$ expo --version
3.18.6

The package.json file is as follows:

{
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "expo start",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "web": "expo start --web",
    "eject": "expo eject"
  },
  "dependencies": {
    "expo": "^37.0.0",
    "punycode": "^2.1.1",
    "react": "16.9.0",
    "react-dom": "16.9.0",
    "react-native": "https://github.com/expo/react-native/archive/sdk-37.0.1.tar.gz",
    "react-native-url-polyfill": "^1.1.2",
    "react-native-web": "^0.11.7",
    "thwack": "^0.4.1-beta.2",
    "use-thwack": "0.1.0-alpha.2"
  },
  "devDependencies": {
    "@babel/core": "^7.8.6",
    "babel-preset-expo": "^8.1.0"
  },
  "private": true
}

from react-native-url-polyfill.

charpeni avatar charpeni commented on May 18, 2024

Fixed by #200.

from react-native-url-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.