Coder Social home page Coder Social logo

Comments (3)

meowgorithm avatar meowgorithm commented on August 20, 2024 2

Ah, you're probably correct as I believe we're also checking for that again further down the stack. We probably added this in an abundance of caution at some point to avoid any out-of-bounds panics.

Anyway, incase you hadn't figured it out, list items are interfaces that look like this:

type Item interface {
	FilterValue() string
}

So you can just change your implementation of FilterValue to include your item’s description:

type item struct {
	title, description string
}

func (i item) FilterValue() string {
	return i.title + "\n" i.description
}

from bubbles.

Maverobot avatar Maverobot commented on August 20, 2024

It seems that at

if isFiltered && index < len(m.filteredItems) {
, && index < len(m.filteredItems) is unnecessary.

from bubbles.

Maverobot avatar Maverobot commented on August 20, 2024

@meowgorithm Thanks for the tip :)

from bubbles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.