Update to 1.7.9 causes players to have pvp turned on join about pvpmanager

[ChanceSD]

Well, if you can send me the PvPManager config it would help.
So, it has always PvP on right? (In '/pvp status' it shows pvp enabled)

[albatrossen]

Yea if I type /pop status it shows enabled.
Typing /pop then toggles it to disabled, but after logging out and in it is enabled again.
I looked a bit on the code, and noticed players listed in the users.yml by name and uuid due the upgrade. This would naturally toggle old players on pvp once, but does not explain my reconnect example.

I'll post the config later when I'm not using a tablet.
I'll also try to disable pvp log off and check user file for my guid tomorrow

[albatrossen]

ok did some testing. I copied users.yml, toggled pvp status off with /pvp, and diffed the file.
There was indeed a line added but it did not match the UUID of my user...not sure if it mangles it in some way.

[albatrossen]

hmm it is the UUID of a player on the server...perhaps I did the test in a bad way...I'll just try again

[albatrossen]

I tried this.

1. /pvpmanager reload (I assume this would force a write of the users.yml)
2. copied user.yml
3. /pvp to turn off pvp
4. another reload
5. Compared user.yml to copy (my uuid was added)
6. /pvp again but it still turned my flag off

I'm tempted just to add some debug logging to your plugin and compile a local version xD

[18:57:21] [Server thread/INFO]: Faua issued server command: /pvp
[18:57:21] [Server thread/INFO]: [PvP] Faua turned PvP Off!
[18:57:24] [Server thread/INFO]: Faua issued server command: /pvpmanager reload
[18:57:24] [Server thread/INFO]: [PvPManager] Disabling PvPManager v2.1
[18:57:24] [Server thread/INFO]: [PvPManager] Enabling PvPManager v2.1
[18:57:24] [Server thread/INFO]: [PvPManager] Vault Found! Using it for fines punishment
[18:57:24] [Server thread/INFO]: [PvPManager] WorldGuard Found! Enabling WorldGuard Support
[18:57:24] [Craft Scheduler Thread - 10920/INFO]: [PvPManager] Checking for updates...
[18:57:25] [Craft Scheduler Thread - 10920/INFO]: [PvPManager] Update Available: PvPManager v2.1.0
[18:57:25] [Craft Scheduler Thread - 10920/INFO]: [PvPManager] Link: http://dev.bukkit.org/bukkit-plugins/pvpmanager
/
[18:57:26] [Server thread/INFO]: Faua issued server command: /pvp
[18:57:26] [Server thread/INFO]: [PvP] Faua turned PvP Off!

[ChanceSD]

I haven't really took a look at it yet. Will do some debugging soon.

[albatrossen]

and (most of) the config: http://pastebin.com/wamvX0dA
while a bug it is not too urgent...noone have abused the bug on our server yet, so we still have pvpmanager enabled =)
let me know if you need a hand with any testing/debugging ;)

[ChanceSD]

Turns out i just forgot to convert UUID to string when checking if it was in the file xD
Should work fine now.

[albatrossen]

Awesome...thanks for that ;)