Comments (4)
I feel like all arguments that accept "member" should be changed to user
is there any place this wouldnt be acceptable?
from modmail.
I feel like all arguments that accept "member" should be changed to user
is there any place this wouldnt be acceptable?
I think checking user
has more API requests to discord than member
does (I could be wrong), so it's better to use member
where possible. Also there's not many commands that could really benefit from the user
arg other than whitelist
and blacklist
, which I updated in the pr.
from modmail.
The fetch_user
method in discord.py and the fetch_member
method for fetching a member in a guild comparison of API requests
-
fetch_user
-
guild.fetch_member
from modmail.
If you search for the remaining cases where member is still used, you'll realise why they cannot be changed to user.
This issue is fixed in fec862a.
from modmail.
Related Issues (20)
- Subscribe to a ticket HOT 1
- Allowed and denied roles for using ModMail
- Use slash commands, threads, components HOT 4
- Server Discovery channel names HOT 2
- Silent Closing
- Combined Closing Messages
- Open ticket with button or command HOT 2
- Improve blocking feature HOT 2
- Explain how this isn't a scam HOT 1
- replying to a ModMail DM leads to timeout waiting for user reaction HOT 2
- Channel command alternative to msg ModMail HOT 4
- This user id is currently logged on (ID: PiGame) HOT 2
- Backlog queue for tickets HOT 2
- Webhooks for Message Log HOT 3
- feat: Send a message to an open ticket if a user leaves the server HOT 5
- Add 'Create' command for use in server HOT 2
- Commands with a ping prefix, get sent with commandonly mode off.
- [Question] Select menus going forward (d.py update)
- Raspberry Pi Docker Architecture (arm64) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modmail.