Comments (6)
https://github.com/cgkineo/adapt-articleBlockSlider/blob/master/js/adapt-articleView.js#L111
_title: blocks[i].get('title') || blocks[i].get('displayTitle')
from adapt-articleblockslider.
Unfortunately that doesn't help- _title
is being used by both aria-label
& item-button-inner
from adapt-articleblockslider.
Might as well have a bit of a tidy up at the same time...!
_blockSliderConfigureVariables: function() {
var blocks = this.model.getChildren().models;
var itemButtons = [];
blocks.forEach(function(block, i) {
itemButtons.push({
_className: (i === 0 ? 'home' : 'not-home') + (' i'+i),
_index: i,
_includeNumber: i !== 0,
_title: block.get('title')
});
});
this.model.set({
_currentBlock: 0,
_totalBlocks: blocks.length,
_itemButtons: itemButtons
});
}
how about this for the template?
from adapt-articleblockslider.
oh, hang on - is this the one where the item-button
is used both for the progress dots and for the tab buttons??
from adapt-articleblockslider.
just to note the navigation dots are something that were created for a specific project/client and I don't think are normally supported by the out-of-the-box ABS - so not sure this ticket is necessarily relevant (here)
from adapt-articleblockslider.
although note that this feature has been requested in #40 - but I think if we do that we should do it differently to what @jamesrea83 is looking at
from adapt-articleblockslider.
Related Issues (20)
- scrolling issue when media component used in ABS
- Trickle only listening for completion on last tab HOT 3
- when using tabs, it's possible to get a big gap between the tabs and the block content
- rtl in Firefox, Safari: current block not displayed HOT 1
- Require completion before advancing
- add option to disable articleBlockSlider behaviour when accessibility is active
- Remove left arrow on block 1 and right arrow on last block HOT 1
- Add selectable "dots" to show how many blocks there are and to navigate HOT 1
- Enhancement: add mobile specific instruction text option HOT 1
- v5 version: titles are never read out by screenreader
- Simplify extension
- Error HOT 2
- rewrite
- Breaking in FW 5.14.0 HOT 3
- Extra tab on article trickle HOT 2
- Adding to existing course HOT 1
- Blocks wrapping beneath each other HOT 1
- Default breakpoint now medium
- archived - superseded by adapt-sideways
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adapt-articleblockslider.