Comments (4)
Okay, I've found the problem. It happens during the evaluation if a possible move is a castle out of the check. At this point it is not verified if the move involves the king at all. e2g1 is therefore evaluated as if the king moved e1g1. Fixed on my pull request.
from chessnut.
Nice work. Let me verify tonight & I'll merge the fix.
from chessnut.
I merged the pull request with the fix & then noticed that the test could be simplified & more efficiently conducted by splitting the conditional. Those changes were included in the push to fix issue 10.
It currently passes all of the unit tests (including a new one for this issue), but I'll wait to see if you have any comments before I uprev the library release in the pypi package.
Thanks again.
from chessnut.
I ran the new code on my data and I got nothing. Thanks!
from chessnut.
Related Issues (11)
- Improper Invalid Move Error
- invalid get_moves() results
- IndexError: list index out of range HOT 1
- Possible to check for mate? HOT 14
- (Rewrite only) King safety
- Status Codes - Who wins? HOT 2
- Cache Error
- Issue with pip installing Chessnut module HOT 2
- Allow short algebraic notation HOT 1
- A pawn cannot put a king in check on the last line
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chessnut.