Coder Social home page Coder Social logo

Comments (4)

BastiTee avatar BastiTee commented on August 23, 2024

Okay, I've found the problem. It happens during the evaluation if a possible move is a castle out of the check. At this point it is not verified if the move involves the king at all. e2g1 is therefore evaluated as if the king moved e1g1. Fixed on my pull request.

from chessnut.

cgearhart avatar cgearhart commented on August 23, 2024

Nice work. Let me verify tonight & I'll merge the fix.

from chessnut.

cgearhart avatar cgearhart commented on August 23, 2024

I merged the pull request with the fix & then noticed that the test could be simplified & more efficiently conducted by splitting the conditional. Those changes were included in the push to fix issue 10.

It currently passes all of the unit tests (including a new one for this issue), but I'll wait to see if you have any comments before I uprev the library release in the pypi package.

Thanks again.

from chessnut.

BastiTee avatar BastiTee commented on August 23, 2024

I ran the new code on my data and I got nothing. Thanks!

from chessnut.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.