Comments (3)
Thanks for the pull request.
Just wondering what version of Material UI you are running against? Is it version 4.something?
The current build of Muirwik is against 3.9.1... I imagine there might be quite a few changes needed to go to 4, but I have not tested that yet... maybe there is not as much as I first thought (especially if you are running against 4.something and things are mostly working :-) )...
I have got a few changes still to push for version 3.9.3, so will have a look at pulling in your change when I get to 4 :-)
from muirwik.
Oh, I forgot to mention that I'm using Material UI 4.1.3.
I have used only a few components for now and everything (excluding this issue) was working well, so maybe it won't be so hard to port it to v4.
I liked this library (as far as I know, this is the only working MUI binding for Kotlin/JS) and I would like to contribute. But this is my first touch with React, Material UI and JS world at all, so for now I will be filling issues if I find one and doing some pull requests for them if they are simple enough like this one.
from muirwik.
Cool, that explains it.
I will close this issue for now as it relates to version 4. When we move to 4.x there will probably be quite a few warnings to fix... so I will use your pull request then :-). Also, thanks for the update on using v4 reasonably OK... might look at the move to 4 sooner.
Muirwik was my first touch with React, JS, npm, webpack, etc too :-)... was a big learning curve (though I think I am still on the incline :-) ).
from muirwik.
Related Issues (20)
- Not building (on Windows?) HOT 4
- immutable grid item element style HOT 2
- Add Autocomplete Component HOT 3
- Add date picker support HOT 6
- Bintray seems to be dead HOT 2
- Change MinWidth of a mTab HOT 3
- Replace JCenter repository HOT 1
- Is js(LEGACY) still needed? HOT 2
- Missed mBox component HOT 1
- mAutoComplete: defaultValue props type HOT 2
- Error: Can't resolve '@material-ui/core/styles/createMuiTheme' HOT 11
- Upgrade failure HOT 5
- IllegalArgumentException HOT 2
- Support for Material UI 5 HOT 4
- Update to follow Kotlin react HOT 2
- In mListItem with button=false autoFocus is not work HOT 3
- Update to 1.6.10 HOT 2
- Question: Is there a way to change the icon size of alert using `mAlert` function HOT 2
- [Question] How to change padding using attrs.padding in mTable? HOT 2
- IR Support for version 0.10.1 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muirwik.