Coder Social home page Coder Social logo

Comments (3)

cfnz avatar cfnz commented on June 29, 2024

Thanks for the pull request.
Just wondering what version of Material UI you are running against? Is it version 4.something?

The current build of Muirwik is against 3.9.1... I imagine there might be quite a few changes needed to go to 4, but I have not tested that yet... maybe there is not as much as I first thought (especially if you are running against 4.something and things are mostly working :-) )...

I have got a few changes still to push for version 3.9.3, so will have a look at pulling in your change when I get to 4 :-)

from muirwik.

karol-202 avatar karol-202 commented on June 29, 2024

Oh, I forgot to mention that I'm using Material UI 4.1.3.
I have used only a few components for now and everything (excluding this issue) was working well, so maybe it won't be so hard to port it to v4.

I liked this library (as far as I know, this is the only working MUI binding for Kotlin/JS) and I would like to contribute. But this is my first touch with React, Material UI and JS world at all, so for now I will be filling issues if I find one and doing some pull requests for them if they are simple enough like this one.

from muirwik.

cfnz avatar cfnz commented on June 29, 2024

Cool, that explains it.

I will close this issue for now as it relates to version 4. When we move to 4.x there will probably be quite a few warnings to fix... so I will use your pull request then :-). Also, thanks for the update on using v4 reasonably OK... might look at the move to 4 sooner.

Muirwik was my first touch with React, JS, npm, webpack, etc too :-)... was a big learning curve (though I think I am still on the incline :-) ).

from muirwik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.