Coder Social home page Coder Social logo

Use LombScargleFast from gatspy? about cesium HOT 4 CLOSED

bnaul avatar bnaul commented on June 8, 2024
Use LombScargleFast from gatspy?

from cesium.

Comments (4)

stefanv avatar stefanv commented on June 8, 2024

How hard would it be to update gatspy to calculate the same statistical quantities? Or, can we build those on top of gatspy? How does the output of gatspy compare to ours?

from cesium.

bnaul avatar bnaul commented on June 8, 2024

I think it's mostly doable. The major things not included in gatspy are:

  • Support for multiple frequencies --> easy to build on top
  • Automatic selection of regularization parameter --> implementing this exactly the same way that ours works is probably not possible; however, achieving something functionally equivalent might be
  • Statistical significance of fit --> easy to build on top
  • Estimate linear trend --> would need to add to gatspy but this seems straightforward and like a sensible addition

My preference would be to ditch our implementation altogether since I think it is literally unmaintainable (I have spent hours looking at the code and about 50% of it is still totally inscrutable) and adds an additional layer of complexity (compiling Cython code) to our stack with little benefit.

from cesium.

acrellin avatar acrellin commented on June 8, 2024

I strongly vote for replacing the TCP implementation with gatspy if possible. If we don't understand it and can't maintain it, we shouldn't be using it.

from cesium.

stefanv avatar stefanv commented on June 8, 2024

I agree. If we can contribute missing functionality back to gatspy and
build the rest on top, that'd be excellent.
On Dec 4, 2015 12:12 PM, "acrellin" [email protected] wrote:

I strongly vote for replacing the TCP implementation with gatspy if
possible. If we don't understand it and can't maintain it, we shouldn't be
using it.


Reply to this email directly or view it on GitHub
#111 (comment).

from cesium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.