broken display of detailed record pages about opendata.cern.ch

[ntarocco]

It might be related to this change. Can you share what is your version of Flask-Limiter?

[tiborsimko]

It might be related to this change. Can you share what is your version of Flask-Limiter?

That may be it. We are using registry.cern.ch/inveniosoftware/almalinux:1 with Python 3.9.

With invenio-app 1.5.0, Flask-Limiter was 2.9.2 (leading to the issue).

Pinning invenio-app back to 1.4.0, Flask-Limiter is 1.1.0 (and things work).

[slint]

From some quick grepping around Invenio modules, it looks like inveniosoftware/invenio-records-ui#101 is the only instance of a view function wrapped with functools.partial. Explicitly adding __qualname__ should fix the issue.

We don't have this issue currently on Zenodo (and default InvenioRDM installation); an easy way to check is to run:

import functools

# check app view functions
assert not [v for v in app.view_functions.values() if isinstance(v, functools.partial)]

# check api view functions
api_app = app.wsgi_app.app.mounts['/api']
assert not [v for v in api_app.view_functions.values() if isinstance(v, functools.partial)]

I think it all still depends on if you want to upgrade Flask-Limiter, we'll probably go without the pin for Zenodo, so we'll have some initial live testing on Zenodo Sandbox for a while.