Coder Social home page Coder Social logo

Comments (9)

gbitzes avatar gbitzes commented on July 25, 2024

I see, thanks for reporting this issue. I'm not intimately familiar with MacOS, please feel free to send a pull request.

Do you know from which version and on the Linux kernel provides the uuid symbols? If it works on SLC6, we could drop libuuid dependency entirely.

from davix.

amadio avatar amadio commented on July 25, 2024

Sure, I will make a PR. For Linux I looked a bit more and the header /usr/include/linux/uuid.h does not have uuid_generate_random() in it. For Linux we need libuuid-devel (rpm), uuid-dev (deb), or sys-apps/util-linux (Gentoo Linux only) to get the uuid/uuid.h header and library. But on Macs the header seems to be sufficient.

Is it possible to compile Davix without OpenSSL support? I wonder because you have find_package(OpenSSL) and not find_package(OpenSSL REQUIRED) in `CMakeLists.txt.

from davix.

amadio avatar amadio commented on July 25, 2024

Also, I see that you have cmake_minimum_required(VERSION 2.6) in your CMakeLists.txt. Would you consider increasing to 3.0.2, or do you want to maintain backward compatibility as much as possible?

from davix.

gbitzes avatar gbitzes commented on July 25, 2024

About openssl: That's likely a mistake, I don't think davix will build without openssl.

About cmake: Minimum supported platform is SLC6, which has cmake3 using an epel package, so it could work.

Is there some feature you need from cmake3?

from davix.

amadio avatar amadio commented on July 25, 2024

I would like to use include(CheckCXXSymbolExists) and I don't see any reference to it in CMake 2.x docs. If SLC6 is the only old platform, I can try on a container and make sure my changes work there.

from davix.

gbitzes avatar gbitzes commented on July 25, 2024

Ok, no worries, feel free to use cmake3, I'll make sure build scripts etc work after your PR.

from davix.

amadio avatar amadio commented on July 25, 2024

Sure, but it would be better if after my PR you don't need any extra changes :-).

from davix.

amadio avatar amadio commented on July 25, 2024

Hi @gbitzes. I just created #27 to try to address this. Could you please try it and let me know if you have any problems? For ROOT's builtin Davix I use the same file, so it takes precedence over the one in Davix itself, and everything is working, but ROOT requires CMake 3.4.3.

from davix.

amadio avatar amadio commented on July 25, 2024

Closed by PR #27, which has been merged.

from davix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.