JIT is incompatible with OpenCensus Extension about opencensus-php

[MrMage]

The extension predates the JIT compiler, and it doesn't really receive future development anymore. In addition, its overriding of zend_execute_ex does cost a bit of performance (~20%).

I used to use this extension in the past (even contributed fixes to it), but mostly leave it disabled these days to benefit from better default performance. Instead, I manually trace performance-critical sections using Tracer::inSpan in the PHP library (i.e. without the native extension); it should get you the insights you need, without the performance penalty.

[kemurayama]

@MrMage Thanks for sharing the performance information !! It is very useful for me when I instrument.
Do you have any recommendation when we want to capture traces with third party libraries (such as DB) ?
If I used Tracer::inSpan, I would want to trace more specifically to figure out if the latency comes from my implementation or not.

[MrMage]

I trace e.g. all Laravael controller route handlers and all DB queries automatically. From there, I know which routes are slow, and can add more instrumentation to those routes as needed.

Here's the code I use:

app/Http/Controllers/Controller.php

<?php

declare(strict_types=1);

namespace App\Http\Controllers;

use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Routing\Controller as BaseController;
use OpenCensus\Trace\Tracer;

class Controller extends BaseController
{
    use DispatchesJobs,
        ValidatesRequests,
        AuthorizesRequests;

    public function callAction($method, $parameters)
    {
        return Tracer::inSpan(
            [
                'name' => static::class . '::' . $method,
            ],
            fn () => parent::callAction($method, $parameters)
        );
    }
}

app/Database/PostgresConnection.php

<?php

declare(strict_types=1);

namespace App\Database;

use Illuminate\Contracts\Debug\ExceptionHandler;
use Illuminate\Database\Grammar;
use OpenCensus\Trace\Span;
use OpenCensus\Trace\Tracer;

class PostgresConnection extends \Illuminate\Database\PostgresConnection
{
    /* other methods */

    protected function run($query, $bindings, \Closure $callback)
    {
        // Trace any database queries. Alternatively, this could also be implemented by listening to
        // `\Illuminate\Database\Events\QueryExecuted` events; see e.g. `\Spatie\LaravelIgnition\Recorders\QueryRecorder`.
        $args = \func_get_args();
        return Tracer::inSpan(
            [
                'name' => 'DatabaseConnection::run',
                'attributes' => [
                    'query' => $query,
                ],
                'kind' => Span::KIND_CLIENT,
            ],
            // Can't use `\func_get_args()` directly here because the arguments to `fn ()` are empty.
            fn () => parent::run(...$args)
        );
    }
}

[kemurayama]

@MrMage Thanks. These samples are really helpful for me to understand how to instrument the code.
And I really appreciate your kind response.