Comments (5)
Actually the exported types are never useful, we should instead keep the constructors and unexport the types.
func NewWindowCumulative() Window
func NewWindowSlidingCount(count uint64, subSets int) Window
func NewWindowSlidingTime(duration time.Duration, subIntervals int) Window
from opencensus-go.
The types will still be needed by the exporters. That is how we can populate zpages and other exporters.
from opencensus-go.
Can you give more info how the zpages and exporters need these types please? These types don't export anything. Will they be just type casted?
from opencensus-go.
The data collected *ViewData returns the view along with the data collected (aka Rows).
The View have methods to return the interfaces: Window, Aggregation... The exporter needs to type switch on this interface to determine what Window or Aggregation it is and maybe extract or not data from them.
For example WindowSlidingTime needs to have a mehtod Duration() that returns the duration. This will allow the exporter to know that this data was for the last" 30s, 1mn, 5mn or whatever else.
We need Duration() instead of just exporting the field because we want them to be immutable once created.
This also applies to the interface AggregationValue returned in the Rows. It needs to be type switched to the right AggregationDistributionValue, AggregationCountValue...
from opencensus-go.
from opencensus-go.
Related Issues (20)
- Remove rakyll from being an auto-assignee for reviews HOT 3
- metric: document how to use the Registry and export metrics out HOT 1
- Test_Worker_MultiExport intermittently fails: Mismatched value
- Defining stats and views for dynamically created endpoints HOT 4
- stats: defaultWorker can not be stopped HOT 1
- [ochttp] KeyClientHost tag doesn't change in exported Prometheus metrics
- compile error HOT 1
- Improve performance of stats recording HOT 6
- Tracestate header not generated or mutated
- race condition inside opencensus ochttp when used inside google storage API
- ProbabilitySampler always sample when incoming trace-id is 64-bit (B3/Jaeger)
- Span name with stack trace
- Tag has concurrent access problem
- Is there a function or way to transfor `view.Data` to `WriteRequest` HOT 2
- Testify needs updating due to DOS and Null ptr dereference - plz update testify to >= 1.7.5
- Security issue: recording query params insecure (tokens) HOT 7
- Panic when running stats.Record without importing the view package
- ochttp.Handler.ServeHTTP func param r * http.Request did not modify r.MultipartForm correctly HOT 3
- Hash pin github workflow dependencies
- Memory statistics never collected unless UseDerivedCumulative is used
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opencensus-go.