Notification Icons for AIMSICD about android-imsi-catcher-detector

[SecUpwN]

Simply awesome. Thank you so much for your commitment to our project, @SgtObst! I'll be asking this to @xLaMbChOpSx and @E3V3A: Do you prefer adding the flat UI sense-style Icons to the notification bar, or would you rather go with the three logos that have already been pushed (the ones on top of this page). I prefer using those in the notification bar instead of the flat UI icons. What do you think?

[SgtObst]

Hm, I think it's a nice option for the users! I can push the flat ones also!

[SecUpwN]

@SgtObst, as I already said, the topmost three Icons would be poper to be used as notification. But since there seems to be no way to convince you not to design new Icons 😈 (I very much like your enthusiasm for our project here), this is my name suggestion for the three different stiles:

Sense-Style Icons (set as standard notification Icons):

• Red Icon: sense_alarm.png
• Grey Icon: sense_idle.png
• Green Icon: sense_good.png

White circled Icons (can be chosen via settings menu):

• Red Icon: white_alarm.png
• Grey Icon: white_idle.png
• Green Icon: white_good.png

Flat UI Style (can be chosen via settings menu):

• Red Icon: flat_alarm.png
• Grey Icon: flat_idle.png
• Green Icon: flat_good.png

How does that sound to you, @SgtObst? Before submitting the pull request, I would like to hear the opinion of @xLaMbChOpSx on this as he will have to rename all the respective variables in the code and update the settings menu to enable selection of the Icon type for the notification bar.

[SgtObst]

@SecUpwN, sounds nice. Let's wait for @xLaMbChOpSx and his opinion.
So there will be sense styled as "sense"; white circled as "white" and flat onecoloured as "flat"

Is this ok?

[SecUpwN]

Cool thing is: I can edit all posts. Are you OK with the new names, @SgtObst?
Corrected everything, waiting for feedback of @xLaMbChOpSx now. 😸

[E3V3A]

Again all Great! Only recommendation is to change order of the names to be: "style"_"alarm".png that way they're easier to spot when we get more...

[SecUpwN]

@E3V3A: Changed the style names accordingly. @xLaMbChOpSx, your opinion?

[xLaMbChOpSx]

Great work @SgtObst the Icons look awesome!! I have compiled a build with them this morning as it looks sweet! :) I think the naming style is good as well allowing for easy identification of the different styles.

[SecUpwN]

Without opening a new Issue for this: Changing the Icon style on v0.1.5-alpha does not yet work as expected: Icons only seem to change upon complete reboot. Is it possible to enable the change to take immediate effect? I really ❤️ what you've done so far to the original source code, @xLaMbChOpSx.

[xLaMbChOpSx]

Yes I ran out of time last night so could not fully implement the shared preferences change listener so it will save the charges you make but unfortunately won't update the icon style until after a restart, killing the server and then restarting the app should also load the change.

I will complete this shortly so it functions correctly.

[SecUpwN]

Hmm.. still no immediate Icon change on version 0.1.6. Did you forget it, @xLaMbChOpSx? ^^

[E3V3A]

@SgtObst Can you please add two more colors and possibly one with a skull?

We will have the following threat levels:

---

Code	Threat Level
1. Green	NORMAL
2. Yellow	MEDIUM
3. Orange	HIGH
4. Red	DANGEROUS
5. Black	RUN!

---

[SecUpwN]

@E3V3A, great suggestion, I like the idea with the skull! @SgtObst, hope this task is not too difficult for you: We'd have to have 45 (!) Icons in total then (if you want to make all Icons for "Sense", "Flat UI" and "White"). Asking this into the room: Wouldn't it be better to only have ONE Icons Style (voting for "Sense")?

[E3V3A]

@SecUpwN Actually I have not been able to understand which is the default ones, as the settings radio buttons (oh another issue?) are all blank. Can you post the icons with names in the XDA thread? Personally I like the 3 first ones and would be fine with having just one style for simplicity, but since this function is already there, we might as well leave it in, until autum-cleaning time. (We can use the different sets for debugging and testing.)

[SecUpwN]

@E3V3A, there is not much to explain: Basically, we have 3 different style types for Icons: "Sense" (the default one shown on top of this page), "White" (the ones with the white circle around them) and "Flat UI" (pretty much intensified unicolors). If we now add YELLOW, ORANGE and the SKULL version to it, @SgtObst would have to create additional Icons for every Icon style mentioned. Not sure if he's up for it to do so. Aside from the suggestion of an autumn cleaning (which is a great idea, preparing AIMSICD for 1 year anniversary) I'd like to find a solution for the Icons we can stick with for good. I know you just took these new states from the CatcherCatcher-Project, @E3V3A - but how do you define status "Yellow" or status "Orange"? Wouldn't it be much better to stick with our current simple setup of Green-Idle-Red?

[E3V3A]

@SecUpwN This is not news at all. That detailed info will be in the closed (for public) documents, which will be released once they have been correctly implemented in the app.

[SecUpwN]

@E3V3A, I'm sorry that I obviously didn't get your point. What's the purpose of adding yet another 3 Icons to AIMSICD? I ask this again: Shouldn't we keep the Icon stuff as simple as possible? Personally, I'm very comfortable with 3 Icons - either there's danger or not. And if both is not true, the App is loading. Perfect for me! But if there really are closed documents for why these addidional Icons shall be implemented into AIMSICD, please don't hesitate to send them to me via PM on XDA. Thanks!

[E3V3A]

@xLaMbChOpSx and @SecUpwN I sent you PM with specific design notes, explaining why there would be more than 3 icons. But I'm completely open to discussion, reduction and change of mind, if there are any other convincing counter-arguments.

[SecUpwN]

@E3V3A, after reading your design notes, adding the additional Icons makes perfectly sense. I've just written a friendly message to our Designer, hopefully he'll find a minute to create those. I just gotta say this again: Hats off to the thoughts you wrote down so nicely. Never stop your creative thinking!

[SgtObst]

hi everyone! @xLaMbChOpSx @SecUpwN @E3V3A
im back! and here are the new ones!

the flat and white ones are following. please enjoy them in big size!

[SgtObst]

@SecUpwN @xLaMbChOpSx @E3V3A
that is how it looks like:

What about the new names? Will they be like; white_green; sense_black and flat_orange?
and another question: should i change the transparancy of the white ones also to white? It would look better. That means, only the symbol in the middle will loose its transparency!

vs:

I think the new ones look cool, exept yellow, it hurts a litte bit in the eyes!
I have finishd all options in every dpi! waiting for you ;)

P.S.: As every big app has several types of icons, especially a second pair for the status bar, we should stay with this configuration! We also could set which Icons should be shown where! That would mean, that e.g. the new white ones or flat ones are used in status bar and the sense ones only in the main app, it's your choice! I'll test the app, as soon as possible, but maybe we could use one big sense one ( 500p e.g.) on top of the main page of the app as a big status!

[E3V3A]

@SgtObst Wow! Really fantastic job!
BTW. Is the grey "idle" icon still there? (I think we need it.) The "sense" ones are perfect. About the transparency, I don't know, but I agree that white "tower" on yellow background hurts your eyes...

[SgtObst]

@E3V3A Yes idle is still there, but as I only count 5 Threat Level, I reduced the samples to 5.

[SecUpwN]

@SgtObst, just.. WOW. Amazing job! What's your opinion on this, @xLaMbChOpSx? Please also make a statement about the naming of the Icons in terms of what would be best for you to code them in.

[mva1985]

those look exceptional. .. really! !!

[SecUpwN]

Ok, it seems as if implementing the new Icons has not been accomplished yet because of naming Issues and possibly a lack of time on the side of @xLaMbChOpSx. Time to clarify some things. To answer the questions of @SgtObst: I like your idea of changing the transparency of the white Icons also to white, but can you re-adjust the yellow Icon to not hurt the eyes? Maybe use another (darker) yellow?

Furthermore, I've thought about a "new" naming scheme related to threat levels which we can extend upon (if wanted) - could you please name the new Icons accordingly, @SgtObst?

CODE	THREAT-LEVEL	SENSE	WHITE	FLAT
Grey	LOADING	sense_idle.png	white_idle.png	flat_idle.png
Green	NORMAL	sense_ok.png	white_ok.png	flat_ok.png
Yellow	MEDIUM	sense_medium.png	white_medium.png	flat_medium.png
Orange	HIGH	sense_high.png	white_high.png	flat_high.png
Red	DANGER	sense_danger.png	white_danger.png	flat_danger.png
Black	SKULL	sense_skull.png	white_skull.png	flat_skull.png

Please tell us what you think @E3V3A. If you like it, please change the naming values within AIMSICD and adjust for integration of the the new Icons, @xLaMbChOpSx. We love your work, don't forget that!

[xLaMbChOpSx]

@SgtObst @SecUpwN @E3V3A The icons look really awesome!! I agree that the yellow with the white is a little harsh on the eyes but the other option you provided looks really good.

I will integrate them immediately when I see the commit adding them to the repo and the suggested naming values all look good to me.

[SgtObst]

Ok, seems to be allright. I will change the yellow and then try to commit them as soon as possible.

[SecUpwN]

Not to be pushing you or anything, but what happened to your commit, @SgtObst? 😺

[SgtObst]

@SecUpwN @E3V3A @xLaMbChOpSx
I have pushed the commit successfully, but somehow some old ones with wrong names still exist. Maybe someone should clean it up!

[SecUpwN]

@SgtObst, huuge THANKS for the awesome pull request! I already noticed that some Icons lack the new naming, I will clear this up as soon as I find a minute (writing this in the middle of the night, sleep is a BIATCH). Nevertheless, thanks again, glad to have you here as our main designer on this project! ;-)

@xLaMbChOpSx, would you please be so kind to incorporate the new Icons for threat levels "Medium", "High" and "Run!"? I've already changed all Icon names according to the new naming scheme and also corrected the current codebase to reflect these changes (f2b6966). Let's just forget what happened the last few days, I'll buy you as many beers as you want once you're in Germany one day (promised). 🍻