Mempool evicition about celestia-core

[adlerjohn]

Here's how I think we can do this.

1. A blob is accepted into the mempool. Tendermint doesn't interpret the blob. (no change)
2. CheckTx takes in a blob and returns a list of transactions IDs. Each transaction ID is the hash of the non-witness data. Since each blob in the mempool could correspond to multiple transactions, we need to return a list here. (change)
3. Blobs in the mempool are links to two IDs:
   1. Hash of the blob in its entirety. This is used at the p2p layer for unconfirmed txs, i.e. before accepting a new tx, check against the blob hash, (unchanged)
   2. List of transactions IDs. This is used for evicting confirmed txs. When receiving a new block, evict any txs from the mempool that are included in the block based on transactions ID.(change)
4. In order to evict txs that are seen in a block, DeliverTx should return a since transaction ID.

[liamsi]

related: tendermint/spec#201
and tendermint/tendermint#7917

[liamsi]

A first, non-invasive approach (at least for the tendermint side) would be to use "re-check" for evicting the mempool:

https://github.com/tendermint/tendermint/blob/f9c54d2710d7a83b2d40fd96f973a0ffba75e740/mempool/clist_mempool.go#L639-L656
and
https://github.com/tendermint/tendermint/blob/f9c54d2710d7a83b2d40fd96f973a0ffba75e740/mempool/clist_mempool.go#L464-L485

This means that the app needs to track the (mempool) Tx, that it processed and "accepted" in the preprocess step.

[liamsi]

As per the above this isn't something urgent and IMO we can close this for now.