Coder Social home page Coder Social logo

Comments (5)

liamsi avatar liamsi commented on August 15, 2024 1

Also, to quote a go core dev:

replace is intended to support local development, not permanent forks: if you need to permanently fork a dependency, your fork must have its own, unique import path.

from celestia-core.

liamsi avatar liamsi commented on August 15, 2024 1

Closing for now.

from celestia-core.

liamsi avatar liamsi commented on August 15, 2024

One observation is that tendermint (and hence ll-core) uses some internal package(s) (e.g. github.com/tendermint/tendermint/tools/tm-signer-harness/internal or github.com/tendermint/tendermint/crypto/internal/benchmarking) which doesn't seem to work well with the replace directive.
E.g.,

package github.com/lazyledger/lazyledger-core/tools/tm-signer-harness
        tools/tm-signer-harness/main.go:14:2: use of internal package github.com/tendermint/tendermint/tools/tm-signer-harness/internal not allowed

We might be able to work around this though.

But even if I remove all packages (it's mostly test packages, eg. the tm-signer-harness and the bench_tests for the sig libs), there are still a lot of errors. I'll push a branch with my findings so far.

from celestia-core.

liamsi avatar liamsi commented on August 15, 2024

https://github.com/lazyledger/lazyledger-core/tree/ismail/experiment_with_replace

from celestia-core.

liamsi avatar liamsi commented on August 15, 2024

TBH, I don't think replace is meant to be used like this (replace the module that you are defining), only to replace dependencies (which could be forks).

from celestia-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.