Return Minified Asset With Full URL about minify

[ceesvanegmond]

Thx for the issue. I will soon look into it.

[ceesvanegmond]

Do you think this has to be an config option or set it per minify set?

[fer-ri]

I think its better to per minify set

On 10 May 2014 02:12, Cees van Egmond [email protected] wrote:

Do you think this has to be an config option or set it per minify set?

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-42702929
.

[ceesvanegmond]

Do you have an proposal?

[ceesvanegmond]

@ghprod Something like this?

<?= Minify::javascript(array('/js/jquery.js'))->fullUrl() ?>

[ceesvanegmond]

@ghprod I've implemented this feature on the develop branch. Could you try this?

<?= Minify::javascript(array('/js/jquery.js'))->fullUrl() ?>

Works also for stylesheet, if it works i'll merge it in master.

[fer-ri]

Nice, i've tried and its works nice:)

Thanks, now you can merge into master

[amalfra]

How about adding a config or something so that always full url can be set to return?

[ceesvanegmond]

@ghprod What do you think of @amalfra argument?

[ceesvanegmond]

@ghprod or maybe withFullUrl() instead of fullUrl()

[fer-ri]

For me its not a problem about naming your method :)
and about @amalfra suggestion, its ok to add about that, but then above
method will not work?

On 14 May 2014 02:33, Cees van Egmond [email protected] wrote:

@ghprod https://github.com/ghprod or maybe withFullUrl() instead of
fullUrl()

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-43001506
.

[ceesvanegmond]

Merged into master, going to bump version

[amalfra]

Thats cool.... So, what about the configuration option so that i won't have to call the full url every time. I think it would be handy. What think you?