support for binary payload about fivebeans

[ceejbot]

That is an excellent suggestion, thank you.

[ceejbot]

I think I have a fix for you that doesn't require you to pass encodings or change how you use the API at all. You do now get buffers back instead of strings by default, so how you handle your job data might need to change a little. My goal was to not need to touch any of the existing unit tests but still be able to submit binary data & get it back again intact, so you might not need to do anything. Will look at it again in the morning & push a new version to npm if I still like this approach.

[clowwindy]

Awesome! Now works with binary data. But there is a problem with UTF-8 strings:

var fs = require('fs');

var fivebeans = require('fivebeans');
var client = new fivebeans.client();
var client2 = new fivebeans.client();

// var data = fs.readFileSync('binary_file');
// var data = 'string containing only ascii chars';
var data = 'utf-8 string υρεςτγχγγθεшгкп';

console.log(data);

client.connect(function (err) {
    client2.connect(function (err) {
        client.use('default', function (tubename) {
            console.log(tubename);

            client.put(1, 0, 60, data, function (err, jobid) {
                console.log(err, jobid);
            });
        });

        client2.watch('default', function (err, numwatched) {
            client2.reserve(function (err, jobid, payload) {
                console.log(payload);
                for (var i = 0; i < data.length; i++) {
                    if (typeof data == 'string') {
                        console.assert(data.charCodeAt(i) == payload[i]);
                    } else {
                        console.assert(data[i] == payload[i]);
                    }
                }
            });
        });
    });
});

$ node test.js 
utf-8 string υρεςτγχγγθεшгкп
null
EXPECTED_CRLF undefined

The problem is that the convertion between UTF-8 to string and binary to string is different. I think an easy way to add binary support without changing API is to add an encoding option to constructor.

[ceejbot]

I think I've nailed this now. Please give it a shot. I'll push a new release to npm today after I've had a look at the other open issue.