Coder Social home page Coder Social logo

Comments (8)

bdewater avatar bdewater commented on July 17, 2024 2

https://github.com/cedarcode/webauthn-ruby/network shows the 3-dev branch is fairly old, and so is the v3.0.0.alpha1 tag.

I can get started on a v3.0.0.alpha2 that's on master with the changes for the instance based config, now that there's a 2-stable branch for maintaining the current version.

from webauthn-ruby.

Brantron avatar Brantron commented on July 17, 2024

For a little more context, I would like to use that release, but the diff against the latest version release is fairly substantial v3.0.0.alpha1...v2.5.2 so it feels like getting a path to support this going forward would be really helpful.

from webauthn-ruby.

anero avatar anero commented on July 17, 2024

It's also not possible to use the 3.0.0.alpha1 version with OpenSSL 3.0

from webauthn-ruby.

Brantron avatar Brantron commented on July 17, 2024

For folks that are interested, I think I may have a working solution, although I'm still thinking it out. Here's the pseudocode

class WebauthnClient
  CONFIGURATION_MUTEX = Mutex.new
  
  # synchronize configuration, ensuring the block given has the correct context
  def with_configuration(&_blk)
    CONFIGURATION_MUTEX.synchronize do
      WebAuthn.configure do |config|
        config.origin = context_specific_domain_name
        config.rp_name = context_specific_site_name
      end
      yield
    end
  end
  
  def options_for_registration(webauthn_id:, name:, exclude_credentials: [])
    with_configuration do
      WebAuthn::Credential.options_for_create(
        user: { id: webauthn_id, name: name },
        exclude: exclude_credentials,
      )
    end
  end
end

from webauthn-ruby.

bdewater avatar bdewater commented on July 17, 2024

Getting #368 to work wasn't very hard - some merge conflicts and a few array-indexed tests that needed updating. Please give it a try and report any findings (good or bad) there 🙏

from webauthn-ruby.

Brantron avatar Brantron commented on July 17, 2024

What's not clear to me is why was this reverted in the last attempt?

from webauthn-ruby.

brauliomartinezlm avatar brauliomartinezlm commented on July 17, 2024

I have answered in the PR itself. Just an extra thank you @Brantron for getting the conversation started on this and @bdewater for actioning quickly on this! We'll get this sorted out shortly and stop having forked versions and documentation of the API soon.

from webauthn-ruby.

brauliomartinezlm avatar brauliomartinezlm commented on July 17, 2024

Closing as we've just released v3.0.0.alpha2

from webauthn-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.