Comments (5)
it looks like this addressed in urllib3 in version 1.8: https://github.com/urllib3/urllib3/blob/master/CHANGES.rst#18-2014-03-04
from ndg_httpsclient.
I never thought that there would be a cert with > 64 subject alt names! :) 64 is just a convenient default from code I adapted for use with this package. As you say, there doesn't seem to be a hard-limit - looking at https://www.ietf.org/rfc/rfc5280.txt I don't think there'll be an easy way to dynamically allocate an arbitrary number of names in the code. When I can get to a decent Internet connection I'll investigate. Failing that I suggest bumping up the limit to 1024. Hopefully no one will want a cert with that many.
from ndg_httpsclient.
I've commited the fix in devel and tested it against https://files.pythonhosted.org. I explicitly set it to match the wildcard *.pythonhosted.org. Please give it a try.
I could make a change to the SAN verification to support wildcards explicitly or it may be better to leave control to the caller to explicitly set the hostname to match.
from ndg_httpsclient.
Release on to PyPI as version 0.5.0
from ndg_httpsclient.
awesome, thanks @philipkershaw! I will check it out soon
from ndg_httpsclient.
Related Issues (11)
- version 0.3.3 does not work with python3 HOT 1
- OpenSSL.SSL.WantReadError
- Wheel support HOT 1
- test certs have expired (20 Jan 2018). Could those be refreshed? HOT 3
- Test certificates expired (again) HOT 4
- test suite fails with openssl 1.1.1e HOT 1
- Setup.py not copying __init__.py into package. HOT 13
- pyasn1 is a dependency that doesn't get upgraded HOT 8
- LICENSE missing from pypi package HOT 2
- v0.4.1 was not pushed to PyPI HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ndg_httpsclient.