Coder Social home page Coder Social logo

Comments (5)

pegler avatar pegler commented on July 22, 2024

it looks like this addressed in urllib3 in version 1.8: https://github.com/urllib3/urllib3/blob/master/CHANGES.rst#18-2014-03-04

from ndg_httpsclient.

philipkershaw avatar philipkershaw commented on July 22, 2024

I never thought that there would be a cert with > 64 subject alt names! :) 64 is just a convenient default from code I adapted for use with this package. As you say, there doesn't seem to be a hard-limit - looking at https://www.ietf.org/rfc/rfc5280.txt I don't think there'll be an easy way to dynamically allocate an arbitrary number of names in the code. When I can get to a decent Internet connection I'll investigate. Failing that I suggest bumping up the limit to 1024. Hopefully no one will want a cert with that many.

from ndg_httpsclient.

philipkershaw avatar philipkershaw commented on July 22, 2024

I've commited the fix in devel and tested it against https://files.pythonhosted.org. I explicitly set it to match the wildcard *.pythonhosted.org. Please give it a try.

I could make a change to the SAN verification to support wildcards explicitly or it may be better to leave control to the caller to explicitly set the hostname to match.

from ndg_httpsclient.

philipkershaw avatar philipkershaw commented on July 22, 2024

Release on to PyPI as version 0.5.0

from ndg_httpsclient.

pegler avatar pegler commented on July 22, 2024

awesome, thanks @philipkershaw! I will check it out soon

from ndg_httpsclient.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.