Comments (10)
Had a better idea. I've added a search icon to the right of 'My Music' - this produces a dialog allowing the search term to be entered. I've removed the 'Search' entry from the list.
Using a dialog will allow me (in the future) to perhaps add more options - such as onyl searching artists, albums, or tracks, etc.
from lms-material.
I do agree that on desktop there is a lot of wasted space in the header. However, where to put search? Really it belongs on the left hand side - as it searches the library which is shown there, and not the queue. But, on the left is the player selection menu. Perhaps in the middle?
I think the following might work:
- If desktop and width>600(?) pix, then show seach field in middle of header.
- Otherwise, show a magnifying glass icon (for mobile, only when on browse view). When button is selected whole header turns into a search field, with a close button.
- Only enable search when at top-level of browse. Otherwise you give the impression that a search from that level on is performed.
Can't always show search in mobile, even if wide, as the details of the currently playing track are shown under the player menu - and this might cause the text to be needlessly truncated.
Does that make sense?
from lms-material.
Yes, that makes sense and is pretty much what I was imagining.
You make a good point though about the arrangement. Thinking out loud a bit here (and with the caveat I've not really used the mobile view):
-
Do the "track information" and "expand now playing" buttons conceptually belong in the playing controls section as they apply to the currently happening activity?
-
A "track information" button could even also appear on each entry in the queue or in the queued tracks' context menus.
-
The settings menu would make sense moved to the far left.
-
With those buttons moved, the player selection menu (and subtitle on mobile) can move over to the far right and be right aligned. This way the player name will be directly next to its volume control and directly above its current queue.
-
You can then put the search at the top left (to the right of the now-moved settings button) and above the library to be searched.
Would that work?
from lms-material.
- Yes, they could be moved there - but not on mobile. I'd like mobile and desktop to be as consistent as possible.
- No. Tack info is for current track, and can be configured to) change when track changes
- Again, no. Android apps, chrome, firefox, etc have this three dotted menu on the right
- Again, no
- Nope, because of the above
The more I think about this, the more I'm coming round to the opinion that its more hassle than its worth.
from lms-material.
Can't determine a good place to put this in the main toolbar. In the middle is jsut odd, to the right and its over the queue, on the left either it's location would change (due to player name label) or there would be a varying gap between the player name label and this.
So, in main toolbar is probably a no-go.
However, as a compromise, how about placing this in the sub-toolbar in the browse page? This is the toolbar that has the home and back icons when navigating. At the top-level it is not currently shown. I could have it always shown, and place search there. This would then balance the browse and queue views more. Sound reasonable?
from lms-material.
Yes, I think that would work.
from lms-material.
Implemented in 81-search-position
branch. But I'm not 100% sure about it.
from lms-material.
I had a play with it, and while it certainly improves on the discoverability problem, I understand your "not 100%" comment about that location.
There's possibly an even simpler solution: how about forcing the search entry to be top of the "My Music" list rather than at the bottom? That way anyone going to the page will see it without having to know to scroll down, and it makes it clear that it only searches "My Music" and not other things.
from lms-material.
The location of 'Search' works for me when not using server-side menus. Scrolling is only required when using server menus. But, I think that it should be in the same location with both. So, still not sure. To me search is not the main interface, so I don't want it at the top of the list.
from lms-material.
With 'Search' back in the list you won't need to force the sub-toolbar to be visible so even placed at the top it should result in roughly the same menu entries being on screen as in 81-search-position
.
Anyway this is your decision; I'm just contributing ideas. The issue was prompted by multiple visitors asking how they can search the library, hence it suggested to me that it is a minor usability issue you might like to be aware of.
Personally I keep the server side menus enables as I like to quickly jump to "New Music" when I'm getting to know new albums.
I suppose I often forget to use 'Search' but now playing with it, it is much faster (especially with the material skin) for people using a keyboard with a specific album, artist or song in mind. It also seems useful for collections where the genres are overly divided into sub-genres.
Reorder-able and hide-able menus would be great but more effort than it's worth, however forcing 'Search' to the top of 'My Music' could always be an toggle option.
from lms-material.
Related Issues (20)
- Lyrics Font Size HOT 4
- Feature request: Sort Artist by Role HOT 1
- [Feature Request] Alarm indicator/info in Player Dialog/Name HOT 5
- Clipped station logos in favourites HOT 1
- Missing icons for iframe pages if set as default
- [Feature Request] Highlight plug-in when update is available HOT 2
- Error when adding favorite; Something went wrong! (AxiosError: Network Error) HOT 4
- More intelligent jumplist trimming HOT 1
- Issues with Material skin in Fully Kiosk Browser HOT 3
- Accessing image file near 350 times HOT 1
- Integration in Home Assistant via iframe disables HA return button HOT 3
- Mobile layout resize after keyboard (APK)
- Bug: Drag'n'Drop in Now Playing not working anymore HOT 4
- Why can't I see the "Albums" icon? HOT 1
- Add Shuffle options to alarms HOT 2
- Suggestion: blur improvements. HOT 3
- [FR] Make the skin OLED safe. HOT 6
- Add option to import favorites HOT 1
- Works - Jumplist does not appear when only 1 release group not including works HOT 2
- Works: Problem with Extended Browse Mode HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lms-material.