Coder Social home page Coder Social logo

Comments (6)

ccloli avatar ccloli commented on May 27, 2024

Hi, I've checked a gallery which most pages have original image download link. With the image limits rule, it should only take 62 * (1 + 5) = 372 limits. When I started, the image limits is 85/5000, so when I finished it should be 372 + 85 = 457.

However, thought it doesn't finished downloading, the image limits has increased to 1065 (with 57 images succeed, 10 failed times, but doesn't request a new image URL).

I'll checked what's up soon, please be patient. As I'm not sure if it is a bug or E-Hentai increased the image limits count (however the update log doesn't show this), I'll mark this issue as Question tag temporarily.

Updated: finally 1167.

from e-hentai-downloader.

ccloli avatar ccloli commented on May 27, 2024

It seems that now E-Hentai use a flexible way to calculate image limits when downloading original images.

From my test, before I viewed this page, my image limits was 1002, after that it's 1003, then I clicked download original image (1559 x 2196 485.1 KB), my limits increased to 1005 (+2).

But when I checked the gallery in previous comment, after I viewed the first page, it's 1006, and after I clicked download original image (2698 x 3840 3.98 MB), it increased to 1025 (+19).

All my test (image with * is NSFW):

So from these test, it seems that the image limits is now calculated by file size, costing 1 limit per 0.2MB (or per 200KB). So it's not a bug of E-Hentai Downloader, but E-Hentai uses a new way to calculate image limits.

I'll update the image limits wiki page soon.

Updated: The wiki page has been updated.

from e-hentai-downloader.

ccloli avatar ccloli commented on May 27, 2024

BTW, with the new calculating ways, maybe I can pre-calculate image limits before user start downloading, so that they can know how many limits will be used.

from e-hentai-downloader.

typhoon71 avatar typhoon71 commented on May 27, 2024

Oh, so the limit is counted based on size now, and the script shows the available points intead of the available images. Got it.
Pre-calculating would be nice, if it's possible, it would help managing the points.
Thanks for discovering what's was going on.

from e-hentai-downloader.

ccloli avatar ccloli commented on May 27, 2024

Now the feature has been added, will be released and enabled by default in next version.

Anyway, it's just an estimated value, as I can't fetch all the pages then calculate how many limits it'll cost before downloading, it's calculated by this:

Page Length + File Total Size (MB) * 5

You can disabled it by checking Settings -> Basic -> Disable pre-calculating image limits cost. It'll be shown on the title of the action box, like Estimated Limits Cost: 6258.

qq 20161005190104

from e-hentai-downloader.

typhoon71 avatar typhoon71 commented on May 27, 2024

Nice, thanks.

from e-hentai-downloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.