Assertion failure on Windows UNC paths about ccache

[jrosdahl]

It seems like 3cacab8 somehow fixes it!

Right, thanks for checking. I'm (very) slowly converting the code to use std::filesystem::path to fix issues like these.

[mablanchard]

Adding debug prints in util::is_absolute_path() gives:

dir=S:/[...]/clang15.0.3
path=UNC/[...]/clang15.0.3/lib/clang/15.0.3/include/vadefs.h

And indeed, it seems like ccache has no understanding of these UNC/ paths. Debugging this little further shows that these kind of paths are generated by GetFinalPathNameByHandle() at src/Util.cpp#L1021.

[mablanchard]

It seems like 3cacab8 somehow fixes it! std::filesystem::canonical() gives, in util::is_absolute_path():

dir=S:/[...]/clang15.0.3
path=///[...]/clang15.0.3/lib/clang/15.0.3/include/vadefs.h

Witch is properly handled.

[mablanchard]

Yep, I could see that, should fix a lot of these kind of problems indeed! Speaking of which, do you plan on implementing util::to_absolute_path() with std::filesystem::absolute()? I think this would allow resolving Windows path of the kind C:foo\bar (ie. foo\bar relative to current working dir. for C:).

[jrosdahl]

Yep, I could see that, should fix a lot of these kind of problems indeed! Speaking of which, do you plan on implementing util::to_absolute_path() with std::filesystem::absolute()?

Yes, or rather remove it since it won't be needed anymore.