Initial pkpass support about android

[TheLastProject]

Comment by TheLastProject
Monday Dec 09, 2019 at 16:21 GMT

---

Documentation:
https://developer.apple.com/library/archive/documentation/UserExperience/Reference/PassKit_Bundle/Chapters/TopLevel.html#//apple_ref/doc/uid/TP40012026-CH2-SW1

[TheLastProject]

Comment by TheLastProject
Sunday Dec 15, 2019 at 14:06 GMT

---

I've opted for using a new EXTRAS database field to store this all in, because putting all of this data in the note doesn't seem doable. See brarcher/loyalty-card-locker#309 (comment) for how this looks to the end-user.

[TheLastProject]

Comment by TheLastProject
Sunday Dec 15, 2019 at 18:12 GMT

---

i18n is working, but I need to fix all the tests still:

[TheLastProject]

Comment by TheLastProject
Monday Dec 16, 2019 at 16:10 GMT

---

While not perfect, it does enough to be useable. I guess I consider this to be "ready for review" now, @brarcher.

It's a rather huge change, so to explain the architecture a bit:

• There's a new ExtrasHelper which stores "extra" data. The reason for this is that (1) note doesn't support i18n, (2) there's simply way too much data to store in a note and still have a decent user experience
• The ExtrasHelper saves to the database as JSON and parses the JSON from the database. This is on purpose because (1) to my knowledge JSON by itself does not have code execution exploit risks like other ways of storing data does, (2) it makes it easy to share it with the existing share feature and (3) there are no real guarantees as to what fields there will be which makes it difficult to create a good DB structure for

Some notes:

• I'm honestly not happy with the whole codebase being filled with throws JSONException now, but I'm not sure how else to make this work...
• Android intents are very confusing but this at least consistently works for downloaded .pkpass files in a file manager.
• We lack a proper i18n chain. Right now it's just user's preferred language -> en -> untranslated. This means that if Android returns es_AR for example, we'll likely fail to return the es translation and will instead return the en one. I do not yet know how to properly fix this.

[TheLastProject]

Comment by TheLastProject
Wednesday Dec 18, 2019 at 11:19 GMT

---

I couldn't resist and I'm sure the legal worries of #303 don't apply when they literally put the icon in the file that's provided.

[TheLastProject]

Comment by airon90
Saturday Feb 22, 2020 at 08:27 GMT

---

I suppose that the name of the app should be changed, as boarding cards or event tickets are not loyalty cards. I am going to open a new issue about that.

[TheLastProject]

Comment by TheLastProject
Saturday Feb 22, 2020 at 14:05 GMT

---

I personally would keep the app name the same and just write in the description it also supports event tickets and stuff.

[TheLastProject]

Closed in favour of #69.