Coder Social home page Coder Social logo

Comments (6)

obfusk avatar obfusk commented on August 19, 2024 1

I'm guessing this is a request for the search to also include cards whose group matches the query string?

from android.

TheLastProject avatar TheLastProject commented on August 19, 2024 1

Well, that would break filtering if you're in any group (if you'd search Pharmacy while in the Pharmacy group it won't filter anything) so it would need extra logic to filter out the current group. At which point what the search does will become inconsistent based on which group you're currently viewing.

Given swiping to the group you want shouldn't take long (perhaps we can look into if there is a better way to handle a large amount of groups than horizontal scrolling so switching becomes faster) and disabling your search is also just a single tap on the X (or a swipe back), I think I'd much rather prioritize the search feature being simple, consistent and logical. The group names not being searched is what I think most people would expect given the group is a filter on the top of the screen already (so you're choosing the group to search), and thus most users would logically switch groups instead. Thus, making this change would make the search behaviour less logical and consistent.

So I don't think it's a good idea to implement this, I think it's likely to cause more confusion than be helpful, so I'm going to close this with a wontfix.

from android.

TheLastProject avatar TheLastProject commented on August 19, 2024

I'm sorry, but I don't understand what you're asking for here.

from android.

Korb avatar Korb commented on August 19, 2024

@obfusk, exactly, thanks for the succinct explanation!

from android.

Korb avatar Korb commented on August 19, 2024

if you'd search Pharmacy while in the Pharmacy group it won't filter anything

Exactly! That's how it should be! Only cards from this group will be displayed, and nothing else. It’s like entering some analogue of “all” in a general list. What would you expect to see in the Pharmacy group if you were to type Pharmacy into it? You don't expect that, being in the Pharmacy group, when you type the word Pharmacy in the search, you will see something other than Pharmacy in the search results, or not see all the cards in the Pharmacy group?

so it would need extra logic to filter out the current group. At which point what the search does will become inconsistent based on which group you're currently viewing.

I don’t see the connection between the example you gave and the consequence of the need to do different search logic depending on whether the group tag filter has already been applied to the general list of cards or not. (After all, at the level of functional concepts, groups here are simply a set of tags assigned to cards, with subsequent visualization through predefined filters in the form of tabs.) Simply, now a user administering a card database for several users will have to add to the description of each card the names of the groups in which each card is displayed. And change the descriptions after each change in the groups to which the card is added. Although, this manual synchronization (duplication of entities) could be implemented through search without changing the principle of its operation.

from android.

obfusk avatar obfusk commented on August 19, 2024

You don't expect that, being in the Pharmacy group, when you type the word Pharmacy in the search, you will see something other than Pharmacy in the search results, or not see all the cards in the Pharmacy group?

If I have a group named "Books" and I'm looking for a store that actually has "Books" in its name, I would not expect it to show everything in the group instead of just the stores that actually have "Books" in their name.

IMO it might make some sense to also look at group names only when no group is selected. But then "what the search does will become inconsistent based on which group you're currently viewing". I agree with Sylvia here that it's probably better to prioritise consistency here.

from android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.